Details
-
Type:
Improvement
-
Status: Open
-
Priority:
Major
-
Resolution: Unresolved
-
Affects Version/s: 3.2.0-b1
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
Description
When editing a package there is an option to remove a package pricing. As of 3.1.1, the system prevents deleting pricings if there exists a service in the system that uses that pricing.
Instead, what should happen is that pricing should be made inactive. An inactive pricing will not appear when editing a package pricing. However, if editing a service that uses that package pricing, the inactive package pricing will be displayed and selected as the currently used term. If the service no longer uses that term it will no longer appear in the list of terms.
When listed in the list of terms it should be denoted by "(DELETED)".
See related CORE-997.
Activity
Even when a price override is set for a service, it is still linked to a package pricing id. Therefor, it is likely necessary to do both.
1. Soft delete the pricing id
2. Set a price override
Paul Phillips
added a comment - Even when a price override is set for a service, it is still linked to a package pricing id. Therefor, it is likely necessary to do both.
1. Soft delete the pricing id
2. Set a price override Since price overrides now exist, I wonder if instead we should set a price override for all services who's package pricing is being removed.
Saving the package should require a confirmation, that indicates that services exist that use the pricing being deleted. They will have the option to cancel (and not save the package) or continue, in which case all those services will be updated to use a price override.
Paul Phillips
added a comment - Since price overrides now exist, I wonder if instead we should set a price override for all services who's package pricing is being removed.
Saving the package should require a confirmation, that indicates that services exist that use the pricing being deleted. They will have the option to cancel (and not save the package) or continue, in which case all those services will be updated to use a price override. 
Probably requires a new column to package_pricing called status, enum "active", "inactive". All existing pricing should be updated to active. Deleting a package pricing should mark it as inactive.
Inactive pricing should be listed when editing a package, but designated as inactive in some way. Ideally, inactive pricings would be hidden by default, and you would have to click a link or button to display them. It may be desirable for staff to update inactive pricing to change recurring pricing for legacy customers.