Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-2199

Module group add order for round robin should consider the limit

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 4.0.0-b1
        • Fix Version/s: 4.1.0-b1
        • Component/s: Modules
        • Labels:
          None

          Description

          The round-robin priority schedule used by the abstract module to choose a module row should consider the account limit setting.

          Currently, it only considers the total. By not considering the account limit for a module row, it's possible to exceed it.

          Consider 2 module rows added in a group:

          1. Used 5, limit 5
          2. Used 5, limit 10

          In this case, round-robin would choose the first option, exceeding the limit.
          i.e.

          1. Used 6, limit 5
          2. Used 5, limit 10

          However, it is preferable to select all module rows that have not yet been exceeded before exceeding them. CORE-2138 would then make this soft limit into a hard limit of not exceeding them at all.

            Issue Links

            relates to

            Improvement - An improvement or enhancement to an existing feature or task. CORE-2138 Add option to module groups to force module limits

            • Major - Major loss of function.
            • Closed

            Improvement - An improvement or enhancement to an existing feature or task. CORE-2192 Update module system to select module row by callback

            • Major - Major loss of function.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              tyson Tyson Phillips (Inactive) created issue -
              tyson Tyson Phillips (Inactive) made changes -
              Field Original Value New Value
              Link This issue relates to CORE-2192 [ CORE-2192 ]
              tyson Tyson Phillips (Inactive) made changes -
              Link This issue relates to CORE-2138 [ CORE-2138 ]
              tyson Tyson Phillips (Inactive) made changes -
              Story Points 3
              tyson Tyson Phillips (Inactive) made changes -
              Rank Ranked higher
              tyson Tyson Phillips (Inactive) made changes -
              Sprint 4.1.0 Sprint 2 [ 39 ]
              jonathan Jonathan Reissmueller made changes -
              Assignee Jonathan Reissmueller [ jonathan ]
              Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
              Status Open [ 1 ] In Progress [ 3 ]
              Automated transition triggered when Jonathan Reissmueller created pull request #252 in Stash -
              Status In Progress [ 3 ] In Review [ 5 ]
              Resolution Fixed [ 1 ]
              jonathan Jonathan Reissmueller made changes -
              Fix Version/s 4.1.0 [ 11007 ]
              Fix Version/s Short Term [ 10800 ]
              Automated transition triggered when Tyson Phillips (Inactive) merged pull request #252 in Stash -
              Status In Review [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  jonathan Jonathan Reissmueller
                  Reporter:
                  tyson Tyson Phillips (Inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    17/Jul/17

                    Agile