Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 3.4.2
-
Fix Version/s: 4.1.0-b1
-
Component/s: None
-
Labels:None
Description
It's possible that a credit can exist for an amount less than the precision displayed for that currency in the interface. e.g. $10.009
Attempting to record a payment by using the credit to pay an invoice may then fail. In the admin interface, this error is encountered:
"One or more Amount to Pay values could not be applied to the specified invoice. Ensure that the Amount to Pay does not exceed the Amount Due on the invoice, that the invoice is open, and the sum of the Amount to Pay values do not exceed the Payment or Credit Amount."
e.g.
Attempt to pay an invoice totaling $10.01 with a credit of $10.009
$10.009 < $10.01, so the amount is not enough to pay the invoice. However, I think the credit amount may need to be rounded to cover the payment. $total may need to be rounded in Transactions::validateApplyAmounts
Issue Links
- relates to
-
CORE-1092
Round amounts based on currency format
-
- Closed
-
Activity
Tyson Phillips (Inactive)
created issue -
Tyson Phillips (Inactive)
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
Cody Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Cody Phillips (Inactive)
made changes -
I'm thinking CORE-1092 might be blocking this. Without looking at the currency in question to observe the proper number of decimal places required we can't round accurately.
Cody Phillips (Inactive)
added a comment - I'm thinking CORE-1092 might be blocking this. Without looking at the currency in question to observe the proper number of decimal places required we can't round accurately. Cody Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Paul Phillips
made changes -
| Fix Version/s | 3.5.0 [ 10401 ] | |
| Fix Version/s | 3.4.3 [ 10613 ] |
Cody Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Cody Phillips (Inactive)
made changes -
| Rank | Ranked lower |
Paul Phillips
made changes -
| Rank | Ranked higher |
Paul Phillips
made changes -
| Fix Version/s | Short Term [ 10800 ] |
Paul Phillips
made changes -
| Rank | Ranked higher |
| Assignee | Tyson Phillips [ tyson ] | Jonathan Reissmueller [ jonathan ] |
Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
| Status | Open [ 1 ] | In Progress [ 3 ] |
Okay so the the problem seems to stem for this line (767 on my current dev branch):
'amount' => $this->CurrencyFormat->cast($credit_amount, $currency_code)
This rounds the apply amount to 2 decimal places, and as far as I can tell there is no good reason for it since that is a mismatch from the database and it is not based on the currency at all.
Automated transition triggered when Jonathan Reissmueller created pull request #287 in Stash -
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Sprint | 4.1.0 Sprint 4 [ 38 ] |
| Rank | Ranked lower |
| Fix Version/s | 4.1.0 [ 11007 ] | |
| Fix Version/s | Short Term [ 10800 ] |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.1.0 Sprint 4 [ 38 ] | 4.1.0 Sprint 4, 4.1.0 Sprint 5 [ 38, 42 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Automated transition triggered when Tyson Phillips (Inactive) merged pull request #287 in Stash -
| Status | In Review [ 5 ] | Closed [ 6 ] |
If rounding, the rounding must observe the decimal precision of the currency itself, not some arbitrary value (like 2, for example).