Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 3.0.0, 3.4.3
-
Fix Version/s: 3.5.0-b2
-
Component/s: None
-
Labels:None
Description
It appears that when a service renews, if it has a coupon assigned to it, that coupon is applied to the service even if the coupon is specified to only be applied when a service is added.
Looking at the logic, I think this is in Services::buildServiceCouponLineItems:
if ($coupon_applies && $coupons[$service->coupon_id]->limit_recurring == "1") {
The above condition checks whether a coupon has recurring limitations to validate, but I don't see anywhere that it determines whether the coupon applies to recurring services, e.g. where
$coupons[$service->coupon_id]->recurring == "1"
Issue Links
- relates to
-
CORE-1710
One-time coupons do not appear on an invoice
-
- Closed
-
Activity
Tyson Phillips (Inactive)
created issue -
Tyson Phillips (Inactive)
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
Tyson Phillips (Inactive)
made changes -
| Status | Open [ 1 ] | In Progress [ 3 ] |
Tyson Phillips (Inactive)
made changes -
| Status | In Progress [ 3 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
Tyson Phillips (Inactive)
made changes -
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Tyson Phillips (Inactive)
made changes -