Details
Bug
Major
Description
A service to renew currently occurs via Services::getAllPaidPending by checking that a service has a non-null last renew date, and an invoice that has been paid associated with the service since the last time the cron ran to renew services.
This is not enough criteria to distinguish whether the paid invoice for the service is indeed for a renewal. The invoice could be for a service option, a term/package change, or something else.
The proposed resolution is to specifically associate a renewal invoice with its service. Only when one of these invoices is paid would the service renew.
When a service renewal date is bumped, an invoice is created for it. This is the invoice that should be saved as the renewal invoice. Once this invoice has been paid, the service should be renewed, and the associated record of the renewal invoice should be removed.
New table:
`service_invoices`
`service_id`, `invoice_id`
When the cron runs to create a service renewal invoice, add it to `service_invoices`.
When the invoice is paid in full, the Services::getAllRenewablePaid method (or another method) called from the cron should check the `service_invoices` table to determine any of the invoices has been paid. For every paid invoice, renew the service, and remove the records from `service_invoices` table.
Issue Links
Activity
Tyson Phillips (Inactive)
created issue -
Tyson Phillips (Inactive)
made changes -
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Tyson Phillips (Inactive)
made changes -
| Fix Version/s | 4.1.1 [ 11015 ] | |
| Fix Version/s | 4.2.0-b1 [ 11014 ] | |
| Fix Version/s | Short Term [ 10800 ] |
Tyson Phillips (Inactive)
made changes -
| Assignee | Jonathan Reissmueller [ jonathan ] |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.2.0 Sprint 1 [ 44 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Rank | Ranked higher |
| Remaining Estimate | 0 minutes [ 0 ] | |
| Time Spent | 25 minutes [ 1500 ] | |
| Worklog Id | 10219 [ 10219 ] |
Automated transition triggered when Jonathan Reissmueller created pull request #313 in Stash -
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Time Spent | 25 minutes [ 1500 ] | 31 minutes [ 1860 ] |
| Worklog Id | 10219 [ 10219 ] |
| Description |
A service to renew currently occurs via _Services::getAllPaidPending_ by checking that a service has a non-null last renew date, and an invoice that has been paid associated with the service since the last time the cron ran to renew services.
This is not enough criteria to distinguish whether the paid invoice for the service is indeed for a renewal. The invoice could be for a service option, a term/package change, or something else. The proposed resolution is to specifically associate a renewal invoice with its service. Only when one of these invoices is paid would the service renew. When a service renewal date is bumped, an invoice is created for it. This is the invoice that should be saved as the renewal invoice. Once this invoice has been paid, the service should be renewed, and the associated record of the renewal invoice should be removed. New table: `service_invoices` _`service_id`, `invoice_id`_ When the cron runs to create a service renewal invoice, add it to `service_invoices`. When the invoice is paid in full, the _Services::getAllRenewablePaid_ method (or another method) called from the cron should check the `service_invoices` table to determine any of the invoices has been paid. For every paid invoice, renew the service, and remove the records from `service_invoices` table. |
A service to renew currently occurs via _Services::getAllPaidPending_ by checking that a service has a non-null last renew date, and an invoice that has been paid associated with the service since the last time the cron ran to renew services.
This is not enough criteria to distinguish whether the paid invoice for the service is indeed for a renewal. The invoice could be for a service option, a term/package change, or something else. The proposed resolution is to specifically associate a renewal invoice with its service. Only when one of these invoices is paid would the service renew. When a service renewal date is bumped, an invoice is created for it. This is the invoice that should be saved as the renewal invoice. Once this invoice has been paid, the service should be renewed, and the associated record of the renewal invoice should be removed. New table: `service_invoices` _`service_id`, `invoice_id`_ When the cron runs to create a service renewal invoice, add it to `service_invoices`. When the invoice is paid in full, the _Services::getAllRenewablePaid_ method (or another method) called from the cron should check the `service_invoices` table to determine any of the invoices has been paid. For every paid invoice, renew the service-, and remove the records from `service_invoices` table-. |
| Description |
A service to renew currently occurs via _Services::getAllPaidPending_ by checking that a service has a non-null last renew date, and an invoice that has been paid associated with the service since the last time the cron ran to renew services.
This is not enough criteria to distinguish whether the paid invoice for the service is indeed for a renewal. The invoice could be for a service option, a term/package change, or something else. The proposed resolution is to specifically associate a renewal invoice with its service. Only when one of these invoices is paid would the service renew. When a service renewal date is bumped, an invoice is created for it. This is the invoice that should be saved as the renewal invoice. Once this invoice has been paid, the service should be renewed, and the associated record of the renewal invoice should be removed. New table: `service_invoices` _`service_id`, `invoice_id`_ When the cron runs to create a service renewal invoice, add it to `service_invoices`. When the invoice is paid in full, the _Services::getAllRenewablePaid_ method (or another method) called from the cron should check the `service_invoices` table to determine any of the invoices has been paid. For every paid invoice, renew the service-, and remove the records from `service_invoices` table-. |
A service to renew currently occurs via _Services::getAllPaidPending_ by checking that a service has a non-null last renew date, and an invoice that has been paid associated with the service since the last time the cron ran to renew services.
This is not enough criteria to distinguish whether the paid invoice for the service is indeed for a renewal. The invoice could be for a service option, a term/package change, or something else. The proposed resolution is to specifically associate a renewal invoice with its service. Only when one of these invoices is paid would the service renew. When a service renewal date is bumped, an invoice is created for it. This is the invoice that should be saved as the renewal invoice. Once this invoice has been paid, the service should be renewed, and the associated record of the renewal invoice should be removed. New table: `service_invoices` _`service_id`, `invoice_id`_ When the cron runs to create a service renewal invoice, add it to `service_invoices`. When the invoice is paid in full, the _Services::getAllRenewablePaid_ method (or another method) called from the cron should check the `service_invoices` table to determine any of the invoices has been paid. For every paid invoice, renew the service, -and remove the records from `service_invoices` table-. |
| Time Spent | 31 minutes [ 1860 ] | 1 hour, 42 minutes [ 6120 ] |
| Worklog Id | 10251 [ 10251 ] |
| Time Spent | 1 hour, 42 minutes [ 6120 ] | 2 hours, 56 minutes [ 10560 ] |
| Worklog Id | 10254 [ 10254 ] |
Automated transition triggered when Tyson Phillips (Inactive) merged pull request #313 in Stash -
| Status | In Review [ 5 ] | Closed [ 6 ] |
