Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-2199

Module group add order for round robin should consider the limit

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.0-b1
    • Fix Version/s: 4.1.0-b1
    • Component/s: Modules
    • Labels:
      None

      Description

      The round-robin priority schedule used by the abstract module to choose a module row should consider the account limit setting.

      Currently, it only considers the total. By not considering the account limit for a module row, it's possible to exceed it.

      Consider 2 module rows added in a group:

      1. Used 5, limit 5
      2. Used 5, limit 10

      In this case, round-robin would choose the first option, exceeding the limit.
      i.e.

      1. Used 6, limit 5
      2. Used 5, limit 10

      However, it is preferable to select all module rows that have not yet been exceeded before exceeding them. CORE-2138 would then make this soft limit into a hard limit of not exceeding them at all.

        Issue Links

          Activity

            People

            • Assignee:
              jonathan Jonathan Reissmueller
              Reporter:
              tyson Tyson Phillips (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                17/Jul/17

                Agile