Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-2221

Deleting a pending service as a client may make a module cancel request

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.6.1
    • Fix Version/s: 4.0.0-b1
    • Component/s: None
    • Labels:
      None

      Description

      Deleting a pending service as an admin deletes the pending service in Blesta only, and does not make a module call to cancel the service. However, cancelling a pending service as a client may make a module cancel request.

      This is especially problematic in the following scenario:

      1. Client places a duplicate order for the same hosting service (assume cPanel)
      2. Client pays for 1 order, which is provisioned, and then cancels the duplicate pending service
      3. A module call is made to the cPanel server to cancel the service. Because the username matches a live account, the live service is cancelled when it should not be.

      Solution

      We need to do 1 of the following:

      1. Do not allow clients to cancel pending services or
      2. Do not "Use Module" when clients cancel Pending services

      I sort of prefer #1. Thoughts?

      Originally reported here - http://www.blesta.com/forums/index.php?/topic/6896-clear-dysfunction-with-blestas-workflow/

        Activity

        admin Paul Phillips created issue -
        admin Paul Phillips made changes -
        Field Original Value New Value
        Rank Ranked higher
        admin Paul Phillips made changes -
        Description Deleting a pending service as an admin deletes the pending service in Blesta only, and does not make a module call to cancel the service. However, cancelling a pending service as a client may make a module cancel request.

        This is especially problematic in the following scenario:

        # Client places a duplicate order for the same hosting service (assume cPanel)
        # Client pays for 1 order, which is provisioned, and then cancels the duplicate pending service
        # A module call is made to the cPanel server to cancel the service. Because the username matches a live account, the live service is cancelled when it should not be.


        Solution

        We need to do 1 of the following:

        # Do not allow clients to cancel pending services *or*
        # Do not "Use Module" when clients cancel Pending services

        I sort of prefer #1. Thoughts?
        Deleting a pending service as an admin deletes the pending service in Blesta only, and does not make a module call to cancel the service. However, cancelling a pending service as a client may make a module cancel request.

        This is especially problematic in the following scenario:

        # Client places a duplicate order for the same hosting service (assume cPanel)
        # Client pays for 1 order, which is provisioned, and then cancels the duplicate pending service
        # A module call is made to the cPanel server to cancel the service. Because the username matches a live account, the live service is cancelled when it should not be.


        Solution

        We need to do 1 of the following:

        # Do not allow clients to cancel pending services *or*
        # Do not "Use Module" when clients cancel Pending services

        I sort of prefer #1. Thoughts?

        Originally reported here - http://www.blesta.com/forums/index.php?/topic/6896-clear-dysfunction-with-blestas-workflow/
        jonathan Jonathan Reissmueller made changes -
        Assignee Jonathan Reissmueller [ jonathan ]
        Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
        Status Open [ 1 ] In Progress [ 3 ]
        Automated transition triggered when Jonathan Reissmueller created pull request #153 in Stash -
        Status In Progress [ 3 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]
        jonathan Jonathan Reissmueller made changes -
        Fix Version/s 4.0.0 [ 10603 ]
        jonathan Jonathan Reissmueller made changes -
        Fix Version/s Short Term [ 10800 ]
        Automated transition triggered when Tyson Phillips (Inactive) merged pull request #153 in Stash -
        Status In Review [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            admin Paul Phillips
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              15/Sep/16