Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 4.1.0-b1
-
Component/s: None
-
Labels:None
Description
Many people, such as developers, or those wishing to make custom changes, have an issue using our current "_custom" language file because it is included with Blesta, and therefore subject to being overwritten on Blesta updates.
We should add support for "developer-only" custom language file. It would be assumed to exist in Blesta's language directory for the particular language, e.g. "/languages/en_us/FILE.php"
We will not include this file with Blesta, but someone can add it, if they wish to their own installation, and Blesta will attempt to load it. Any language definitions set will be available.
Activity
Tyson Phillips (Inactive)
created issue -
Tyson Phillips (Inactive)
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Story Points | 2 |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.1.0 Sprint 1 [ 38 ] |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.1.0 Sprint 1 [ 38 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked lower |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.1.0 Sprint 2 [ 39 ] |
Tyson Phillips (Inactive)
made changes -
| Assignee | Tyson Phillips [ tyson ] |
| Assignee | Jonathan Reissmueller [ jonathan ] |
Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
| Status | Open [ 1 ] | In Progress [ 3 ] |
Definitely neither of those. It should follow the same format of beginning with an underscore. We should probably include an example file in the installation so people don't have to start from scratch.
Something like _global-example.php. It should contain valid php with comments describing to rename the file to _global.php and an example $lang definition or two to illustrate how they work. It should also specify that custom language definitions can be created here. If they collide with existing language definitions, the ones in this file will be overridden by the other definition. It does not take precedence (and be sure it does not take precedence). I don't think we could allow it to take precedence because it would have to be loaded last, which is not an option.
Tyson Phillips (Inactive)
added a comment - Definitely neither of those. It should follow the same format of beginning with an underscore. We should probably include an example file in the installation so people don't have to start from scratch.
Something like _global-example.php . It should contain valid php with comments describing to rename the file to _global.php and an example $lang definition or two to illustrate how they work. It should also specify that custom language definitions can be created here. If they collide with existing language definitions, the ones in this file will be overridden by the other definition. It does not take precedence (and be sure it does not take precedence). I don't think we could allow it to take precedence because it would have to be loaded last, which is not an option. We already have _custom.php could this not simply work by changing that to _custom-example.php?
No, we already use the _custom language in the core of Blesta.
Tyson Phillips (Inactive)
added a comment - No, we already use the _custom language in the core of Blesta.
Automated transition triggered when Jonathan Reissmueller created pull request #258 in Stash -
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
Tyson Phillips (Inactive)
made changes -
| Fix Version/s | 4.1.0 [ 11007 ] | |
| Fix Version/s | Short Term [ 10800 ] |
Automated transition triggered when Tyson Phillips (Inactive) merged pull request #258 in Stash -
| Status | In Review [ 5 ] | Closed [ 6 ] |
Sorry, I'm a little unsure. What do you want the filename to be? FILE.php? developer-only.php? Something else?