Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-2337

Creating a recurring invoice can result in an SQL error on 'taxable' column

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Minor
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 4.0.0-b6
        • Component/s: Staff Interface
        • Labels:
          None

          Description

          The following error can occur when adding (and presumably editing) a recurring invoice:

          General error: 1366 Incorrect integer value: '' for column 'taxable' at row 1

          This likely occurs on some databases with sql_mode STRICT_TRANS_TABLES. I suspect that adding a recurring invoice includes a 'taxable' value in vars, but it is set to an empty string. Instead, it should not be set at all so that the table will default it to 0.

            Activity

            Ascending order - Click to sort in descending order
            tyson Tyson Phillips (Inactive) created issue -
            tyson Tyson Phillips (Inactive) made changes -
            Field Original Value New Value
            Rank Ranked higher
            tyson Tyson Phillips (Inactive) made changes -
            Sprint 4.0.0 Sprint 17 [ 35 ]
            tyson Tyson Phillips (Inactive) made changes -
            Rank Ranked higher
            Hide
            Permalink
            admin Paul Phillips added a comment -

            Your suspicion appears to be correct regarding STRICT_TRANS_TABLES, at least for one particular customer. See https://www.blesta.com/forums/index.php?/topic/8772-recurring-invoice-bug/

            Show
            admin Paul Phillips added a comment - Your suspicion appears to be correct regarding STRICT_TRANS_TABLES, at least for one particular customer. See https://www.blesta.com/forums/index.php?/topic/8772-recurring-invoice-bug/
            tyson Tyson Phillips (Inactive) made changes -
            Assignee Tyson Phillips [ tyson ] Jonathan Reissmueller [ jonathan ]
            Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
            Status Open [ 1 ] In Progress [ 3 ]
            Hide
            Permalink
            admin Paul Phillips added a comment -

            I am not able to duplicate this with sql_mode=STRICT_TRANS_TABLES on version 5.5.50-MariaDB. Either I'm not testing properly, or this doesn't affect v5.5.50.

            Show
            admin Paul Phillips added a comment - I am not able to duplicate this with sql_mode=STRICT_TRANS_TABLES on version 5.5.50-MariaDB. Either I'm not testing properly, or this doesn't affect v5.5.50.
            Automated transition triggered when Tyson Phillips (Inactive) created pull request #226 in Stash -
            Status In Progress [ 3 ] In Review [ 5 ]
            Resolution Fixed [ 1 ]
            Hide
            Permalink
            tyson Tyson Phillips (Inactive) added a comment -

            Likely isolated to the MySQL version, which the user did not provide.

            Show
            tyson Tyson Phillips (Inactive) added a comment - Likely isolated to the MySQL version, which the user did not provide.
            Automated transition triggered when Tyson Phillips (Inactive) merged pull request #226 in Stash -
            Status In Review [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                jonathan Jonathan Reissmueller
                Reporter:
                tyson Tyson Phillips (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  3/Mar/17

                  Agile