Details
-
Type: Improvement
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 4.0.0-b5
-
Fix Version/s: 4.5.0-b1
-
Component/s: Staff Interface
-
Labels:None
Description
Blesta logs the IP addresses for user logins, sends new order IP addresses to Maxmind (if enabled in the order plugin) for fraud checks, and uses IP addresses for various GeoIP features.
When Blesta is used under a load balanced environment, $_SERVER['REMOTE_ADDR']; will report the load balancer's IP address and not that of the client. This creates a problem in that Blesta is unaware of the clients actual IP address. (By client, I'm referring to the browser client. This affects both Clients and Staff within Blesta)
If the x-forwarded-for header exists, which is or can be set by a load balancer, we should use this instead everywhere we utilize the client's IP address. See https://www.chriswiegman.com/2014/05/getting-correct-ip-address-php/ for more information on getting the right IP address in such a situation.
Issue Links
Activity
Field | Original Value | New Value |
---|---|---|
Story Points | 3 |
Sprint | 4.5.0 Sprint 1 [ 66 ] |
Rank | Ranked higher |
Sprint | 4.5.0 Sprint 1 [ 66 ] | 4.5.0 Sprint 2 [ 67 ] |
Rank | Ranked lower |
Status | Open [ 1 ] | In Progress [ 3 ] |
Assignee | Tyson Phillips [ tyson ] |
Fix Version/s | 4.5.0-b1 [ 11108 ] |
Fix Version/s | Short Term [ 10800 ] |
Security | Private [ 10000 ] |
Status | In Progress [ 3 ] | In Review [ 5 ] |
Resolution | Fixed [ 1 ] |
Remaining Estimate | 0 minutes [ 0 ] | |
Time Spent | 3 hours, 28 minutes [ 12480 ] | |
Worklog Id | 11670 [ 11670 ] |
Time Spent | 3 hours, 28 minutes [ 12480 ] | 3 hours, 49 minutes [ 13740 ] |
Worklog Id | 11672 [ 11672 ] |
Status | In Review [ 5 ] | Closed [ 6 ] |
This depends on the user's environment, but since the x-forwarded-for header can be easily spoofed, it should only be checked if explicitly set to be checked by an admin with knowledge of the proxy. So we can continue to check the remote address header for the IP address, and use the x-forwarded-for IP address in place of it if configured to do so. And also fallback to the remote address if the x-forwaded-for address is not available or unknown.