Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-2349

Add support for the x-forwarded-for header for load balanced environments

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.0.0-b5
    • Fix Version/s: 4.5.0-b1
    • Component/s: Staff Interface
    • Labels:
      None

      Description

      Blesta logs the IP addresses for user logins, sends new order IP addresses to Maxmind (if enabled in the order plugin) for fraud checks, and uses IP addresses for various GeoIP features.

      When Blesta is used under a load balanced environment, $_SERVER['REMOTE_ADDR']; will report the load balancer's IP address and not that of the client. This creates a problem in that Blesta is unaware of the clients actual IP address. (By client, I'm referring to the browser client. This affects both Clients and Staff within Blesta)

      If the x-forwarded-for header exists, which is or can be set by a load balancer, we should use this instead everywhere we utilize the client's IP address. See https://www.chriswiegman.com/2014/05/getting-correct-ip-address-php/ for more information on getting the right IP address in such a situation.

        Issue Links

          Activity

          admin Paul Phillips created issue -
          tyson Tyson Phillips (Inactive) made changes -
          Field Original Value New Value
          Story Points 3
          tyson Tyson Phillips (Inactive) made changes -
          Sprint 4.5.0 Sprint 1 [ 66 ]
          tyson Tyson Phillips (Inactive) made changes -
          Rank Ranked higher
          tyson Tyson Phillips (Inactive) made changes -
          Sprint 4.5.0 Sprint 1 [ 66 ] 4.5.0 Sprint 2 [ 67 ]
          tyson Tyson Phillips (Inactive) made changes -
          Rank Ranked lower
          Automated transition triggered when Tyson Phillips (Inactive) created a branch in Stash -
          Status Open [ 1 ] In Progress [ 3 ]
          tyson Tyson Phillips (Inactive) made changes -
          Assignee Tyson Phillips [ tyson ]
          tyson Tyson Phillips (Inactive) made changes -
          Fix Version/s 4.5.0-b1 [ 11108 ]
          tyson Tyson Phillips (Inactive) made changes -
          Fix Version/s Short Term [ 10800 ]
          tyson Tyson Phillips (Inactive) made changes -
          Security Private [ 10000 ]
          tyson Tyson Phillips (Inactive) made changes -
          Link This issue blocks CORE-2913 [ CORE-2913 ]
          tyson Tyson Phillips (Inactive) made changes -
          Link This issue blocks CORE-2914 [ CORE-2914 ]
          tyson Tyson Phillips (Inactive) made changes -
          Link This issue blocks CORE-2915 [ CORE-2915 ]
          Automated transition triggered when Tyson Phillips (Inactive) created pull request #575 in Stash -
          Status In Progress [ 3 ] In Review [ 5 ]
          Resolution Fixed [ 1 ]
          tyson Tyson Phillips (Inactive) made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 3 hours, 28 minutes [ 12480 ]
          Worklog Id 11670 [ 11670 ]
          jonathan Jonathan Reissmueller made changes -
          Time Spent 3 hours, 28 minutes [ 12480 ] 3 hours, 49 minutes [ 13740 ]
          Worklog Id 11672 [ 11672 ]
          Automated transition triggered when Tyson Phillips (Inactive) merged pull request #575 in Stash -
          Status In Review [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              tyson Tyson Phillips (Inactive)
              Reporter:
              admin Paul Phillips
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                31/Jan/19

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 49 minutes
                3h 49m

                  Agile