Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 4.2.0-b1
-
Component/s: None
-
Labels:None
Description
When a coupon is either expired or has reached it's usage limit, services that coupon is applied to cannot be modified, since the system attempts to re-apply the coupon. This seems to only occur in the admin interface. There are two cases. First when service change queuing is not enabled, the admin immediately receives an error:
That coupon does not appear to be valid.
If service change queuing is enabled then the edit will succeed, but when the cron runs to perform the service change, it returns an error:
Processing service change # resulted in status: Error
If the 'Limitations do apply to service renewals' option is selected and the limit is reached or the coupon expires, then it should continue to apply the coupon regardless.
If the 'Limitations do not apply to service renewals' option is selected and the limit is reached or the coupon expires, then either the coupon should be ignored or an error message should be shown immediately even if service change queuing is enabled.
Issue Links
- relates to
-
CORE-2472
Renewals should not increment coupon usage when limits don't apply
-
- Closed
-
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
Paul Phillips
made changes -
| Issue Type | Bug [ 1 ] | Improvement [ 4 ] |
| Remaining Estimate | 0 minutes [ 0 ] | |
| Time Spent | 50 minutes [ 3000 ] | |
| Worklog Id | 10354 [ 10354 ] |
Tyson Phillips (Inactive)
made changes -
| Story Points | 3 |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.2.0 Sprint 3 [ 48 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked lower |
Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Time Spent | 50 minutes [ 3000 ] | 1 hour, 38 minutes [ 5880 ] |
| Worklog Id | 10440 [ 10440 ] |
Automated transition triggered when Jonathan Reissmueller created pull request #343 in Stash -
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
Tyson Phillips (Inactive)
made changes -
| Fix Version/s | 4.2.0-b1 [ 11014 ] |
Automated transition triggered when Tyson Phillips (Inactive) merged pull request #343 in Stash -
| Status | In Review [ 5 ] | Closed [ 6 ] |
