[CORE-2565] Renewing services are invoiced for 2 month based on proration - Blesta

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 4.2.0
Fix Version/s: 4.2.1, 4.3.0-b1
Component/s: None
Labels:
None

Description

Renewing services are being prorated as if they were being created.

Starting on line 1393 in app/models/invoices.php there should be this code:

                if ($i == 0
                    && ($dates = $this->Packages->getProrataDates(
                        $service->pricing_id,
                        $service->date_added . 'Z',
                        $service->date_renews . 'Z'
                    ))
                ) {

Change that to:

                if ($i == 0
                    && $allow_pro_rata
                    && ($dates = $this->Packages->getProrataDates(
                        $service->pricing_id,
                        $service->date_added . 'Z',
                        $service->date_renews . 'Z'
                    ))
                ) {

Activity

Ascending order - Click to sort in descending order

Jonathan Reissmueller created issue - 27/Dec/17 3:43 PM

Jonathan Reissmueller made changes - 29/Dec/17 11:53 AM

Field	Original Value	New Value
Remaining Estimate		0 minutes [ 0 ]
Time Spent		31 minutes [ 1860 ]
Worklog Id	10663 [ 10663 ]

Tyson Phillips (Inactive) made changes - 29/Dec/17 12:26 PM

Description

Renewing services are being prorated as if they were being created.

Starting on line 1393 in app/models/invoices.php there should be this code:
                if ($i == 0
                    && ($dates = $this->Packages->getProrataDates(
                        $service->pricing_id,
                        $service->date_added . 'Z',
                        $service->date_renews . 'Z'
                    ))
                ) {

Change that to:
                if ($i == 0
                    && $allow_pro_rata
                    && ($dates = $this->Packages->getProrataDates(
                        $service->pricing_id,
                        $service->date_added . 'Z',
                        $service->date_renews . 'Z'
                    ))
                ) {

Renewing services are being prorated as if they were being created.

Starting on line 1393 in app/models/invoices.php there should be this code:
{code}
                if ($i == 0
                    && ($dates = $this->Packages->getProrataDates(
                        $service->pricing_id,
                        $service->date_added . 'Z',
                        $service->date_renews . 'Z'
                    ))
                ) {
{code}

Change that to:
{code}
                if ($i == 0
                    && $allow_pro_rata
                    && ($dates = $this->Packages->getProrataDates(
                        $service->pricing_id,
                        $service->date_added . 'Z',
                        $service->date_renews . 'Z'
                    ))
                ) {
{code}

Tyson Phillips (Inactive) made changes - 29/Dec/17 12:26 PM

Fix Version/s

4.3.0-b1 [ 11019 ]

Tyson Phillips (Inactive) made changes - 29/Dec/17 12:27 PM

Rank

Ranked higher

Tyson Phillips (Inactive) made changes - 29/Dec/17 1:26 PM

Sprint

4.3.0 Sprint 1 [ 49 ]

Tyson Phillips (Inactive) made changes - 29/Dec/17 1:26 PM

Rank

Ranked higher

Tyson Phillips (Inactive) made changes - 29/Dec/17 6:58 PM

Status	Open [ 1 ]	In Review [ 5 ]
Resolution		Fixed [ 1 ]

Automated transition triggered when Tyson Phillips (Inactive) merged pull request #383 in Stash - 02/Jan/18 5:10 PM

Status

In Review [ 5 ]

Closed [ 6 ]

People

Assignee:

Jonathan Reissmueller

Reporter:

Jonathan Reissmueller

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

27/Dec/17 3:43 PM

Updated:

02/Jan/18 5:10 PM

Resolved:

29/Dec/17 6:58 PM

Fix Release Date:

4/Jan/18

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

31m

Agile

Completed Sprint:

4.3.0 Sprint 1 ended 12/Jan/18
View on Board