Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-2568

Update service changes to show multiple coupon fields

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.2.1
    • Fix Version/s: 4.3.0-b1
    • Component/s: Staff Interface
    • Labels:
      None

      Description

      In the admin interface, when updating a service, there is a single Coupon Code field.

      This should be updated to:

      1. Add a new field called Current Coupon Code above the current Coupon Code field that is disabled.
        • This field just displays the coupon code of the current service, if any. It is unused
        • When processing a service change, the existing coupon should be used to process the service change removal
      2. The current Coupon Code field should be blank by default and it refers to the new coupon code to be added for the service change
        • The coupon entered into the Coupon Code field should only be applied to the new service change while the old coupon code is applied to the old service removal

        Issue Links

          Activity

          tyson Tyson Phillips (Inactive) created issue -
          tyson Tyson Phillips (Inactive) made changes -
          Field Original Value New Value
          Link This issue is blocked by CORE-2566 [ CORE-2566 ]
          Hide
          jonathan Jonathan Reissmueller added a comment -

          Currently service changes assume that if a blank value is given for a new coupon, then the coupon is meant to stay the same. It seems that the intent and what really should be done is that if the not given at all then the coupon is meant to stay the same, but if it is empty it should be treated as the removal of the old coupon (This is the difference between an isset() and an empty()).

          Relevant code is currently in app/models/services_changes.php on lines 225-242 under ServiceChanges::getPresenter.

          Show
          jonathan Jonathan Reissmueller added a comment - Currently service changes assume that if a blank value is given for a new coupon, then the coupon is meant to stay the same. It seems that the intent and what really should be done is that if the not given at all then the coupon is meant to stay the same, but if it is empty it should be treated as the removal of the old coupon (This is the difference between an isset() and an empty()). Relevant code is currently in app/models/services_changes.php on lines 225-242 under ServiceChanges::getPresenter.
          tyson Tyson Phillips (Inactive) made changes -
          Rank Ranked higher
          tyson Tyson Phillips (Inactive) made changes -
          Story Points 5
          tyson Tyson Phillips (Inactive) made changes -
          Sprint 4.3.0 Sprint 2 [ 52 ]
          Hide
          tyson Tyson Phillips (Inactive) added a comment -

          I think we are going to add an "Update Coupon" option as a service action, and the Upgrade/Downgrade section will allow you to set a new coupon that applies to the new package/term. The current service coupon will apply to the service you're upgrading from and a new coupon can be set to apply to the new package/term.

          Show
          tyson Tyson Phillips (Inactive) added a comment - I think we are going to add an "Update Coupon" option as a service action, and the Upgrade/Downgrade section will allow you to set a new coupon that applies to the new package/term. The current service coupon will apply to the service you're upgrading from and a new coupon can be set to apply to the new package/term.
          tyson Tyson Phillips (Inactive) made changes -
          Sprint 4.3.0 Sprint 2 [ 52 ] 4.3.0 Sprint 2, 4.3.0 Sprint 3 [ 52, 53 ]
          tyson Tyson Phillips (Inactive) made changes -
          Rank Ranked higher
          Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
          Status Open [ 1 ] In Progress [ 3 ]
          jonathan Jonathan Reissmueller made changes -
          Remaining Estimate 0 minutes [ 0 ]
          Time Spent 28 minutes [ 1680 ]
          Worklog Id 10724 [ 10724 ]
          jonathan Jonathan Reissmueller made changes -
          Time Spent 28 minutes [ 1680 ] 1 hour, 47 minutes [ 6420 ]
          Worklog Id 10726 [ 10726 ]
          jonathan Jonathan Reissmueller made changes -
          Time Spent 1 hour, 47 minutes [ 6420 ] 2 hours, 44 minutes [ 9840 ]
          Worklog Id 10747 [ 10747 ]
          Automated transition triggered when Jonathan Reissmueller created pull request #397 in Stash -
          Status In Progress [ 3 ] In Review [ 5 ]
          Resolution Fixed [ 1 ]
          tyson Tyson Phillips (Inactive) made changes -
          Sprint 4.3.0 Sprint 2, 4.3.0 Sprint 3 [ 52, 53 ] 4.3.0 Sprint 2, 4.3.0 Sprint 3, 4.3.0 Sprint 4 [ 52, 53, 54 ]
          jonathan Jonathan Reissmueller made changes -
          Time Spent 2 hours, 44 minutes [ 9840 ] 3 hours, 24 minutes [ 12240 ]
          Worklog Id 10793 [ 10793 ]
          jonathan Jonathan Reissmueller made changes -
          Time Spent 3 hours, 24 minutes [ 12240 ] 3 hours, 38 minutes [ 13080 ]
          Worklog Id 10800 [ 10800 ]
          jonathan Jonathan Reissmueller made changes -
          Time Spent 3 hours, 38 minutes [ 13080 ] 3 hours, 48 minutes [ 13680 ]
          Worklog Id 10805 [ 10805 ]
          tyson Tyson Phillips (Inactive) made changes -
          Sprint 4.3.0 Sprint 2, 4.3.0 Sprint 3, 4.3.0 Sprint 4 [ 52, 53, 54 ] 4.3.0 Sprint 2, 4.3.0 Sprint 3, 4.3.0 Sprint 4, 4.3.0 Sprint 5 [ 52, 53, 54, 55 ]
          tyson Tyson Phillips (Inactive) made changes -
          Rank Ranked higher
          jonathan Jonathan Reissmueller made changes -
          Time Spent 3 hours, 48 minutes [ 13680 ] 4 hours [ 14400 ]
          Worklog Id 10837 [ 10837 ]
          tyson Tyson Phillips (Inactive) made changes -
          Sprint 4.3.0 Sprint 2, 4.3.0 Sprint 3, 4.3.0 Sprint 4, 4.3.0 Sprint 5 [ 52, 53, 54, 55 ] 4.3.0 Sprint 2, 4.3.0 Sprint 3, 4.3.0 Sprint 4, 4.3.0 Sprint 5, 4.3.0 Sprint 6 [ 52, 53, 54, 55, 56 ]
          tyson Tyson Phillips (Inactive) made changes -
          Sprint 4.3.0 Sprint 2, 4.3.0 Sprint 3, 4.3.0 Sprint 4, 4.3.0 Sprint 5, 4.3.0 Sprint 6 [ 52, 53, 54, 55, 56 ] 4.3.0 Sprint 2, 4.3.0 Sprint 3, 4.3.0 Sprint 4, 4.3.0 Sprint 5, 4.3.0 Sprint 6, 4.3.0 Sprint 7 [ 52, 53, 54, 55, 56, 57 ]
          tyson Tyson Phillips (Inactive) made changes -
          Rank Ranked higher
          jonathan Jonathan Reissmueller made changes -
          Time Spent 4 hours [ 14400 ] 4 hours, 10 minutes [ 15000 ]
          Worklog Id 10953 [ 10953 ]
          Automated transition triggered when Tyson Phillips (Inactive) merged pull request #397 in Stash -
          Status In Review [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              jonathan Jonathan Reissmueller
              Reporter:
              tyson Tyson Phillips (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                15/Jun/18

                Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 10 minutes
                4h 10m

                  Agile