Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-2579

Adding a config option pricing changes IDs of existing ones

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.2.1
    • Fix Version/s: 4.2.2, 4.3.0-b1
    • Component/s: None
    • Labels:
      None

      Description

      Example:
      We have a configurable option with three pricing terms and we'll give them arbitrary IDs:

      • 1 Month - ID 240
      • 3 Months - ID 241
      • 1 Year - ID 242

      Then by clicking the add button on the 3 Months term and adding another term for 6 Months we get a new list:

      • 1 Month - ID 240
      • 3 Months - ID 241
      • 6 Months - ID 242
      • 1 Year - ID 243

      We can see that the ID 242 has moved from the 1 Year term to the 6 Month term. Any one year services are will now be charged the 6 Month config option pricing.

      This should be updated so that terms keep their IDs. So we would get this:

      • 1 Month - ID 240
      • 3 Months - ID 241
      • 1 Year - ID 242
      • 6 Months - ID 243

      Secondly we should create a migration to update services that have the wrong config option pricing because of this issue. We would search the database for services with config option pricing terms that do not match the service pricing term. Then we would update those options to have a pricing that does match the service pricing. In the case that there is more than one option pricing for the given term we should leave it alone so it can be manually resolved.

        Activity

        jonathan Jonathan Reissmueller created issue -
        Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Automated transition triggered when Jonathan Reissmueller created pull request #391 in Stash -
        Status In Progress [ 3 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]
        jonathan Jonathan Reissmueller made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 1 hour, 8 minutes [ 4080 ]
        Worklog Id 10682 [ 10682 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Original Estimate 0 minutes [ 0 ]
        Affects Version/s 4.2.1 [ 11020 ]
        tyson Tyson Phillips (Inactive) made changes -
        Sprint 4.3.0 Sprint 3 [ 53 ]
        tyson Tyson Phillips (Inactive) made changes -
        Rank Ranked higher
        tyson Tyson Phillips (Inactive) made changes -
        Rank Ranked higher
        tyson Tyson Phillips (Inactive) made changes -
        Fix Version/s 4.2.2 [ 11021 ]
        Fix Version/s 4.3.0-b1 [ 11019 ]
        tyson Tyson Phillips (Inactive) made changes -
        Time Spent 1 hour, 8 minutes [ 4080 ] 1 hour, 18 minutes [ 4680 ]
        Worklog Id 10719 [ 10719 ]
        jonathan Jonathan Reissmueller made changes -
        Description Example:
        We have a configurable option with three pricing terms and we'll give them arbitrary IDs:
         - 1 Month - ID 240
         - 3 Months - ID 241
         - 1 Year - ID 242

        Then by clicking the add button on the 3 Months term and adding another term for 6 Months we get a new list:
         - 1 Month - ID 240
         - 3 Months - ID 241
         - 6 Months - ID 242
         - 1 Year - ID 243

        We can see that the ID 242 has moved from the 1 Year term to the 6 Month term. Any one year services are will now be charged the 6 Month config option pricing.
        Example:
        We have a configurable option with three pricing terms and we'll give them arbitrary IDs:
         - 1 Month - ID 240
         - 3 Months - ID 241
         - 1 Year - ID 242

        Then by clicking the add button on the 3 Months term and adding another term for 6 Months we get a new list:
         - 1 Month - ID 240
         - 3 Months - ID 241
         - 6 Months - ID 242
         - 1 Year - ID 243

        We can see that the ID 242 has moved from the 1 Year term to the 6 Month term. Any one year services are will now be charged the 6 Month config option pricing.

        This should be updated so that terms keep their IDs.
        jonathan Jonathan Reissmueller made changes -
        Description Example:
        We have a configurable option with three pricing terms and we'll give them arbitrary IDs:
         - 1 Month - ID 240
         - 3 Months - ID 241
         - 1 Year - ID 242

        Then by clicking the add button on the 3 Months term and adding another term for 6 Months we get a new list:
         - 1 Month - ID 240
         - 3 Months - ID 241
         - 6 Months - ID 242
         - 1 Year - ID 243

        We can see that the ID 242 has moved from the 1 Year term to the 6 Month term. Any one year services are will now be charged the 6 Month config option pricing.

        This should be updated so that terms keep their IDs.
        Example:
        We have a configurable option with three pricing terms and we'll give them arbitrary IDs:
         - 1 Month - ID 240
         - 3 Months - ID 241
         - 1 Year - ID 242

        Then by clicking the add button on the 3 Months term and adding another term for 6 Months we get a new list:
         - 1 Month - ID 240
         - 3 Months - ID 241
         - 6 Months - ID 242
         - 1 Year - ID 243

        We can see that the ID 242 has moved from the 1 Year term to the 6 Month term. Any one year services are will now be charged the 6 Month config option pricing.

        This should be updated so that terms keep their IDs. So we would get this:
         - 1 Month - ID 240
         - 3 Months - ID 241
         - 1 Year - ID 242
         - 6 Months - ID 243

        Secondly we should create a migration to update services that have the wrong config option pricing because of this issue. We would search the database for services with config option pricing terms that do not match the service pricing term. Then we would update those options to have a pricing that does match the service pricing. In the case that there is more than one option pricing for the given term we should leave it alone so it can be manually resolved.

        jonathan Jonathan Reissmueller made changes -
        Time Spent 1 hour, 18 minutes [ 4680 ] 3 hours, 3 minutes [ 10980 ]
        Worklog Id 10725 [ 10725 ]
        jonathan Jonathan Reissmueller made changes -
        Time Spent 3 hours, 3 minutes [ 10980 ] 3 hours, 23 minutes [ 12180 ]
        Worklog Id 10730 [ 10730 ]
        jonathan Jonathan Reissmueller made changes -
        Time Spent 3 hours, 23 minutes [ 12180 ] 3 hours, 49 minutes [ 13740 ]
        Worklog Id 10743 [ 10743 ]
        Automated transition triggered when Tyson Phillips (Inactive) merged pull request #391 in Stash -
        Status In Review [ 5 ] Closed [ 6 ]
        tyson Tyson Phillips (Inactive) made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        tyson Tyson Phillips (Inactive) made changes -
        Time Spent 3 hours, 49 minutes [ 13740 ] 3 hours, 53 minutes [ 13980 ]
        Worklog Id 10757 [ 10757 ]
        tyson Tyson Phillips (Inactive) made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            jonathan Jonathan Reissmueller
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              22/Feb/18

              Time Tracking

              Estimated:
              Original Estimate - 0 minutes
              0m
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 3 hours, 53 minutes
              3h 53m

                Agile