Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-2729

Failure to add a service may cause an error attempting to create an invoice

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.0-b2
    • Component/s: None
    • Labels:
      None

      Description

      When adding a service from the admin UI, Services::add is called. However, no check is done to see whether it set any Input errors, and so it goes on to attempt to create an invoice for the service.

      See AdminClients::createService. Likely need to set a "continue;" after Service::add if Input errors are encountered.
      Mentioned @ https://www.blesta.com/forums/index.php?/topic/10816-input-seterror-no-longer-works-on-addservice-method/&do=findComment&comment=60291

        Activity

        tyson Tyson Phillips (Inactive) created issue -
        tyson Tyson Phillips (Inactive) made changes -
        Field Original Value New Value
        Rank Ranked higher
        tyson Tyson Phillips (Inactive) made changes -
        Sprint 4.3.0 Sprint 11 [ 62 ]
        tyson Tyson Phillips (Inactive) made changes -
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Assignee Jonathan Reissmueller [ jonathan ]
        Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
        Status Open [ 1 ] In Progress [ 3 ]
        jonathan Jonathan Reissmueller made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 55 minutes [ 3300 ]
        Worklog Id 11271 [ 11271 ]
        Automated transition triggered when Jonathan Reissmueller created pull request #468 in Stash -
        Status In Progress [ 3 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]
        jonathan Jonathan Reissmueller made changes -
        Time Spent 55 minutes [ 3300 ] 1 hour, 14 minutes [ 4440 ]
        Worklog Id 11282 [ 11282 ]
        Automated transition triggered when Tyson Phillips (Inactive) merged pull request #468 in Stash -
        Status In Review [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            tyson Tyson Phillips (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              29/Jun/18

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 1 hour, 14 minutes
              1h 14m

                Agile