Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 4.3.0
-
Component/s: None
-
Labels:None
Description
Coupons can have "Apply when service is added only" set. When adding a service from the admin UI or the order form, such coupons are not applied unless the service is a one-time service.
- Fix the issue with coupons not applying to new services as described above.
The below is a separate issue altogether.
Coupons can have "Apply when service is added only" set. When upgrading/downgrade a service through the admin interface, however, these coupons should apply a service that has not yet been renewed.
To do this we need to determine whether a service has been renewed. I can think of a number of ways to do this, but they all have problems.
- Check whether date_last_renewed is empty (A prorated service will have this set on creation).
- Check how many invoices there are associated with this service (An admin can create a service without an invoice).
- Check whether the date_renews is the same as the renew date would be when created base on the pricing and date_added (An admin can change the renew date of a service).
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
Paul Phillips
made changes -
| Fix Version/s | 4.3.0 [ 11022 ] | |
| Fix Version/s | 4.3.0-b2 [ 11100 ] |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.3.0 Sprint 12 [ 63 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Remaining Estimate | 0 minutes [ 0 ] | |
| Time Spent | 2 hours, 48 minutes [ 10080 ] | |
| Worklog Id | 11304 [ 11304 ] |
| Worklog Id | 11304 [ 11304 ] |
Automated transition triggered when Jonathan Reissmueller created pull request #476 in Stash -
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked lower |
Tyson Phillips (Inactive)
made changes -
| Fix Version/s | 4.3.0 [ 11101 ] | |
| Fix Version/s | 4.3.0-b3 [ 11022 ] |
Tyson Phillips (Inactive)
made changes -
Tyson Phillips (Inactive)
made changes -
Tyson Phillips (Inactive)
made changes -
| Description |
Coupons can have "Apply when service is added only" set. When upgrading/downgrade a service through the admin interface, these coupons should apply a service that has not yet been renewed.
To do this we need to determine whether a service has been renewed. I can think of a number of ways to do this, but they all have problems. # Check whether date_last_renewed is empty (A prorated service will have this set on creation). # Check how many invoices there are associated with this service (An admin can create a service without an invoice). # Check whether the date_renews is the same as the renew date would be when created base on the pricing and date_added (An admin can change the renew date of a service). |
Coupons can have "Apply when service is added only" set. When adding a service from the admin UI or the order form, such coupons are not applied unless the service is a one-time service.
# Fix the issue with coupons not applying to new services as described above. The below is a separate issue altogether. ---- Coupons can have "Apply when service is added only" set. When upgrading/downgrade a service through the admin interface, however, these coupons should apply a service that has not yet been renewed. To do this we need to determine whether a service has been renewed. I can think of a number of ways to do this, but they all have problems. # Check whether date_last_renewed is empty (A prorated service will have this set on creation). # Check how many invoices there are associated with this service (An admin can create a service without an invoice). # Check whether the date_renews is the same as the renew date would be when created base on the pricing and date_added (An admin can change the renew date of a service). |
Automated transition triggered when Tyson Phillips (Inactive) merged pull request #476 in Stash -
| Status | In Review [ 5 ] | Closed [ 6 ] |
