Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-2749

Client "In Review" message doubly-encodes service names

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.1
    • Component/s: None
    • Labels:
      None

      Description

      On the client dashboard in the client interface, a blue notice message can be shown if the client has services "in review" pending admin approval. In this case, they will see a message indicating the services pending:

      The following services are pending review by staff. Once approved, they will be activated:
      LogicBoxes 2 .com.co - ελελελ.gr
      LogicBoxes 2 .com.co - saoehuseot.ελ
      UM Temp -

      As can be seen in the above, the domain name for the logicboxes services are UTF-8 characters which are output as HTML-encoded strings (e.g. "&epsilon"). It appears this is because the service name is made HTML-safe when the message is set, but the message output template already outputs the message as HTML-safe, so the double-encoding causes the html entities to be displayed.

      1. Update the client in review message to not make service names HTML-safe since they already are when output

        Activity

        tyson Tyson Phillips (Inactive) created issue -
        tyson Tyson Phillips (Inactive) made changes -
        Field Original Value New Value
        Sprint 4.4.0 Sprint 1 [ 64 ]
        tyson Tyson Phillips (Inactive) made changes -
        Rank Ranked higher
        tyson Tyson Phillips (Inactive) made changes -
        Fix Version/s 4.3.1 [ 11104 ]
        Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
        Status Open [ 1 ] In Progress [ 3 ]
        jonathan Jonathan Reissmueller made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 18 minutes [ 1080 ]
        Worklog Id 11369 [ 11369 ]
        Automated transition triggered when Jonathan Reissmueller created pull request #492 in Stash -
        Status In Progress [ 3 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]
        Automated transition triggered when Tyson Phillips (Inactive) merged pull request #492 in Stash -
        Status In Review [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            tyson Tyson Phillips (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Aug/18

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 18 minutes
              18m

                Agile