Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-2831

Improve hostname validation

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 4.8.0-b1
        • Component/s: None
        • Labels:
          None

          Description

          It would be useful to have a validation service that checks whether a hostname is valid. Currently, there are multiple places in modules, and in the core, that perform similar/identical hostname validation checks. See https://www.blesta.com/forums/index.php?/topic/11833-validatehostname-should-accept-uppercase-characters/

          I'm thinking a new utility under /core/Util/Validate/Server that provides a method to validate a server's hostname. Perhaps another to validate an IP address.

          The Zend framework supports a Hostname validator that appears to handle domain/IDN/IP validation but it's apart of a larger library that requires php 5.6+ and adds up to almost 2MB of files. It may be best in the interim to use php's filter_var with FILTER_VALIDATE_DOMAIN and FILTER_VALIDATE_IP.

            Issue Links

            blocks

            Story - Created by JIRA Agile - do not edit or delete. Issue type for a user story. CORE-3294 Update hostname validation for extensions

            • Major - Major loss of function.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              tyson Tyson Phillips (Inactive) created issue -
              tyson Tyson Phillips (Inactive) made changes -
              Field Original Value New Value
              Rank Ranked higher
              tyson Tyson Phillips (Inactive) made changes -
              Story Points 3
              Hide
              Permalink
              admin Paul Phillips added a comment -

              Depending on complexity, an initial fix for uppercase characters could be made per https://dev.blesta.com/browse/CORE-2832 While it would be good to have a consistent way of validating hostnames which modules can utilize, this shouldn't slow down a fix for resolving uppercase character validation in individually affected modules.

              Show
              admin Paul Phillips added a comment - Depending on complexity, an initial fix for uppercase characters could be made per https://dev.blesta.com/browse/CORE-2832 While it would be good to have a consistent way of validating hostnames which modules can utilize, this shouldn't slow down a fix for resolving uppercase character validation in individually affected modules.
              tyson Tyson Phillips (Inactive) made changes -
              Description It would be useful to have a validation service that checks whether a hostname is valid. Currently, there are multiple places in modules, and in the core, that perform similar/identical hostname validation checks. See https://www.blesta.com/forums/index.php?/topic/11833-validatehostname-should-accept-uppercase-characters/

              I'm thinking a new utility under _/core/Util/Validate/Server_ that provides a method to validate a server's hostname. Perhaps another to validate an IP address.               		It would be useful to have a validation service that checks whether a hostname is valid. Currently, there are multiple places in modules, and in the core, that perform similar/identical hostname validation checks. See https://www.blesta.com/forums/index.php?/topic/11833-validatehostname-should-accept-uppercase-characters/

              I'm thinking a new utility under _/core/Util/Validate/Server_ that provides a method to validate a server's hostname. Perhaps another to validate an IP address.

              The Zend framework supports a Hostname [validator|https://github.com/zendframework/zend-validator] that appears to handle domain/IDN/IP validation but it's apart of a larger library that requires php 5.6+ and adds up to almost 2MB of files. It may be best in the interim to use php's _filter_var_ with _FILTER_VALIDATE_DOMAIN_ and _FILTER_VALIDATE_IP_.
              jonathan Jonathan Reissmueller made changes -
              Rank Ranked higher
              tyson Tyson Phillips (Inactive) made changes -
              Rank Ranked higher
              tyson Tyson Phillips (Inactive) made changes -
              Epic Link CORE-2832 [ 13990 ]
              tyson Tyson Phillips (Inactive) made changes -
              Sprint 4.7.0 Sprint 2 [ 87 ]
              tyson Tyson Phillips (Inactive) made changes -
              Rank Ranked higher
              tyson Tyson Phillips (Inactive) made changes -
              Fix Version/s 4.7.0-b1 [ 11123 ]
              tyson Tyson Phillips (Inactive) made changes -
              Sprint 4.7.0 Sprint 2 [ 87 ] 4.7.0 Sprint 2, 4.7.0 Sprint 3 [ 87, 88 ]
              tyson Tyson Phillips (Inactive) made changes -
              Rank Ranked higher
              tyson Tyson Phillips (Inactive) made changes -
              Sprint 4.7.0 Sprint 2, 4.7.0 Sprint 3 [ 87, 88 ] 4.7.0 Sprint 2, 4.7.0 Sprint 3, 4.7.0 Sprint 4 [ 87, 88, 89 ]
              tyson Tyson Phillips (Inactive) made changes -
              Rank Ranked higher
              tyson Tyson Phillips (Inactive) made changes -
              Sprint 4.7.0 Sprint 2, 4.7.0 Sprint 3, 4.7.0 Sprint 4 [ 87, 88, 89 ] 4.7.0 Sprint 2, 4.7.0 Sprint 3, 4.7.0 Sprint 4, 4.7.0 Sprint 5 [ 87, 88, 89, 90 ]
              tyson Tyson Phillips (Inactive) made changes -
              Rank Ranked higher
              tyson Tyson Phillips (Inactive) made changes -
              Sprint 4.7.0 Sprint 2, 4.7.0 Sprint 3, 4.7.0 Sprint 4, 4.7.0 Sprint 5 [ 87, 88, 89, 90 ] 4.7.0 Sprint 2, 4.7.0 Sprint 3, 4.7.0 Sprint 4, 4.7.0 Sprint 5, 4.7.0 Sprint 6 [ 87, 88, 89, 90, 91 ]
              tyson Tyson Phillips (Inactive) made changes -
              Rank Ranked higher
              admin Paul Phillips made changes -
              Fix Version/s 4.7.0-b2 [ 11125 ]
              Fix Version/s 4.7.0-b1 [ 11123 ]
              admin Paul Phillips made changes -
              Fix Version/s 4.8.0-b1 [ 11127 ]
              Fix Version/s 4.7.0 [ 11125 ]
              tyson Tyson Phillips (Inactive) made changes -
              Sprint 4.7.0 Sprint 2, 4.7.0 Sprint 3, 4.7.0 Sprint 4, 4.7.0 Sprint 5, 4.7.0 Sprint 6 [ 87, 88, 89, 90, 91 ] 4.7.0 Sprint 2, 4.7.0 Sprint 3, 4.7.0 Sprint 4, 4.7.0 Sprint 5, 4.7.0 Sprint 6, 4.8.0 Sprint 1 [ 87, 88, 89, 90, 91, 92 ]
              tyson Tyson Phillips (Inactive) made changes -
              Rank Ranked higher
              Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
              Status Open [ 1 ] In Progress [ 3 ]
              jonathan Jonathan Reissmueller made changes -
              Remaining Estimate 0 minutes [ 0 ]
              Time Spent 54 minutes [ 3240 ]
              Worklog Id 12641 [ 12641 ]
              jonathan Jonathan Reissmueller made changes -
              Time Spent 54 minutes [ 3240 ] 2 hours, 24 minutes [ 8640 ]
              Worklog Id 12643 [ 12643 ]
              Automated transition triggered when Jonathan Reissmueller created pull request #747 in Stash -
              Status In Progress [ 3 ] In Review [ 5 ]
              Resolution Fixed [ 1 ]
              tyson Tyson Phillips (Inactive) made changes -
              Sprint 4.7.0 Sprint 2, 4.7.0 Sprint 3, 4.7.0 Sprint 4, 4.7.0 Sprint 5, 4.7.0 Sprint 6, 4.8.0 Sprint 1 [ 87, 88, 89, 90, 91, 92 ] 4.7.0 Sprint 2, 4.7.0 Sprint 3, 4.7.0 Sprint 4, 4.7.0 Sprint 5, 4.7.0 Sprint 6, 4.8.0 Sprint 1, 4.8.0 Sprint 2 [ 87, 88, 89, 90, 91, 92, 93 ]
              jonathan Jonathan Reissmueller made changes -
              Time Spent 2 hours, 24 minutes [ 8640 ] 4 hours, 17 minutes [ 15420 ]
              Worklog Id 12656 [ 12656 ]
              tyson Tyson Phillips (Inactive) made changes -
              Link This issue blocks CORE-3294 [ CORE-3294 ]
              jonathan Jonathan Reissmueller made changes -
              Time Spent 4 hours, 17 minutes [ 15420 ] 4 hours, 32 minutes [ 16320 ]
              Worklog Id 12673 [ 12673 ]
              Automated transition triggered when Tyson Phillips (Inactive) merged pull request #747 in Stash -
              Status In Review [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  Unassigned
                  Reporter:
                  tyson Tyson Phillips (Inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    23/Dec/19

                    Time Tracking

                    Estimated:
                    Original Estimate - Not Specified
                    Not Specified
                    Remaining:
                    Remaining Estimate - 0 minutes
                    0m
                    Logged:
                    Time Spent - 4 hours, 32 minutes
                    4h 32m

                      Agile