Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-2529 Create invoice pricing presenter
  3. CORE-3021

ImportManager: Replace invoice total calculation

        Details

        • Type: Sub-task
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 4.6.0-b1
        • Component/s: None
        • Labels:
          None

          Description

          The ImportManager migrators call Invoices::getTotal and Invoices::getSubtotal, however, as of CORE-2529, those methods are deprecated. We should update all calls to those methods to use an alternative:

          $presenter = $this->Invoices->getPresenter($invoice_id);
$totals = $presenter->totals();
$totals->subtotal;
$totals->total;

            Issue Links

            is blocked by

            Sub-task - The sub-task of the issue CORE-2545 Update invoice creation to use Invoice presenter

            • Major - Major loss of function.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              tyson Tyson Phillips (Inactive) created issue -
              tyson Tyson Phillips (Inactive) made changes -
              Field Original Value New Value
              Fix Version/s 4.6.0-b1 [ 11117 ]
              tyson Tyson Phillips (Inactive) made changes -
              Link This issue is blocked by CORE-2545 [ CORE-2545 ]
              tyson Tyson Phillips (Inactive) made changes -
              Description The ImportManager migrators call _Invoices::getTotal_, however, as of CORE-2529, that method is deprecated. We should update all calls to _Invoices::getTotal_ to use an alternative:

              {code}
              $presenter = $this->Invoices->getPresenter($invoice_id);
              $presenter->totals()->total;
              {code}               		The ImportManager migrators call _Invoices::getTotal_ and _Invoices::getSubtotal_, however, as of CORE-2529, those methods are deprecated. We should update all calls to those methods to use an alternative:

              {code}
              $presenter = $this->Invoices->getPresenter($invoice_id);
              $totals = $presenter->totals();
              $totals->subtotal;
              $totals->total;
              {code}
              tyson Tyson Phillips (Inactive) made changes -
              Assignee Tyson Phillips [ tyson ]
              Automated transition triggered when Tyson Phillips (Inactive) created a branch in Stash -
              Status Open [ 1 ] In Progress [ 3 ]
              tyson Tyson Phillips (Inactive) made changes -
              Link This issue is blocked by CORE-2545 [ CORE-2545 ]
              tyson Tyson Phillips (Inactive) made changes -
              Link This issue is blocked by CORE-2545 [ CORE-2545 ]
              Automated transition triggered when Tyson Phillips (Inactive) created pull request #11 in Stash -
              Status In Progress [ 3 ] In Review [ 5 ]
              Resolution Fixed [ 1 ]
              Automated transition triggered when Tyson Phillips (Inactive) merged pull request #11 in Stash -
              Status In Review [ 5 ] Closed [ 6 ]

                People

                • Assignee:
                  tyson Tyson Phillips (Inactive)
                  Reporter:
                  tyson Tyson Phillips (Inactive)
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    28/May/19

                    Agile