Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-3060

Update scope of property in GeoIP library

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 4.5.0
    • Fix Version/s: 4.6.0-b1
    • Component/s: None
    • Labels:
      None

      Description

      The GeoIP library (Blesta\Core\Util\GeoIP) classes all define a protected $ip_address property. This property should be private in the abstract class, and not defined at all in the other GeoIP classes since they can use AbstractGeoIp::getIp and AbstractGeoIp::setIp instead.

        Activity

        tyson Tyson Phillips (Inactive) created issue -
        tyson Tyson Phillips (Inactive) made changes -
        Field Original Value New Value
        Rank Ranked higher
        tyson Tyson Phillips (Inactive) made changes -
        Story Points 2
        tyson Tyson Phillips (Inactive) made changes -
        Sprint 4.6.0 Sprint 2 [ 69 ]
        tyson Tyson Phillips (Inactive) made changes -
        Rank Ranked lower
        tyson Tyson Phillips (Inactive) made changes -
        Sprint 4.6.0 Sprint 2 [ 69 ] 4.6.0 Sprint 2, 4.6.0 Sprint 3 [ 69, 79 ]
        tyson Tyson Phillips (Inactive) made changes -
        Rank Ranked higher
        tyson Tyson Phillips (Inactive) made changes -
        Assignee Jonathan Reissmueller [ jonathan ]
        tyson Tyson Phillips (Inactive) made changes -
        Sprint 4.6.0 Sprint 2, 4.6.0 Sprint 3 [ 69, 79 ] 4.6.0 Sprint 2, 4.6.0 Sprint 3, 4.6.0 Sprint 4 [ 69, 79, 80 ]
        tyson Tyson Phillips (Inactive) made changes -
        Rank Ranked higher
        tyson Tyson Phillips (Inactive) made changes -
        Sprint 4.6.0 Sprint 2, 4.6.0 Sprint 3, 4.6.0 Sprint 4 [ 69, 79, 80 ] 4.6.0 Sprint 2, 4.6.0 Sprint 3, 4.6.0 Sprint 4, 4.6.0 Sprint 5 [ 69, 79, 80, 83 ]
        tyson Tyson Phillips (Inactive) made changes -
        Rank Ranked higher
        Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
        Status Open [ 1 ] In Progress [ 3 ]
        Automated transition triggered when Jonathan Reissmueller created pull request #631 in Stash -
        Status In Progress [ 3 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]
        jonathan Jonathan Reissmueller made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 33 minutes [ 1980 ]
        Worklog Id 12073 [ 12073 ]
        Automated transition triggered when Tyson Phillips (Inactive) merged pull request #631 in Stash -
        Status In Review [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            tyson Tyson Phillips (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              28/May/19

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 33 minutes
              33m

                Agile