Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-3077

Add session names as values to the config file

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0.0-b1
    • Component/s: None
    • Labels:
      None

      Description

      The session and cookie names stored in the user's browser set by the application are set in the MinphpBridge service provider. Ideally, these should be configurable, so we should add them to the config file similar to the TTLs. We should also rename them to make them more unique to the application, that way they are less likely to conflict with any other applications on the web server that happen to also use the same session/cookie names.

      1. Create config values in /config/blesta.php for the session name and cookie name
        • Update the MinphpBridge service provider to use these config values
      2. Change the values of the session/cookie names to be more unique to the application
        • cookie "csid" should be "blesta_csid"
        • session "sid" should be "blesta_sid"
      3. In order for an admin to upgrade Blesta to this version, they have to be logged-in, but they wouldn't be in any more once they uploaded the new files for the version since the MinphpBridge looks for and uses a session value that has not yet been created (since the upgrade script hasn't updated the config file). Because of this, we will most-likely need to fallback to the original values ("csid" and "sid") if no value is present in the config file.

        Activity

        tyson Tyson Phillips (Inactive) created issue -
        tyson Tyson Phillips (Inactive) made changes -
        Field Original Value New Value
        Rank Ranked higher
        tyson Tyson Phillips (Inactive) made changes -
        Story Points 2
        tyson Tyson Phillips (Inactive) made changes -
        Fix Version/s 5.0.0-b1 [ 11107 ]
        tyson Tyson Phillips (Inactive) made changes -
        Priority Major [ 3 ] Blocker [ 1 ]
        tyson Tyson Phillips (Inactive) made changes -
        Epic Link CORE-3003 [ 14161 ]
        tyson Tyson Phillips (Inactive) made changes -
        Rank Ranked lower
        jonathan Jonathan Reissmueller made changes -
        Sprint 5.0.0 Sprint 2 [ 118 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked lower
        jonathan Jonathan Reissmueller made changes -
        Assignee Tyson Phillips [ tyson ]
        jonathan Jonathan Reissmueller made changes -
        Sprint 5.0.0 Sprint 1 [ 118 ] 5.0.0 Sprint 2 [ 119 ]
        jonathan Jonathan Reissmueller made changes -
        Assignee Jonathan Reissmueller [ jonathan ]
        Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
        Status Open [ 1 ] In Progress [ 3 ]
        Automated transition triggered when Jonathan Reissmueller created pull request #995 in Stash -
        Status In Progress [ 3 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]
        jonathan Jonathan Reissmueller made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 1 hour, 3 minutes [ 3780 ]
        Worklog Id 14302 [ 14302 ]
        abdy Abdy Franco made changes -
        Time Spent 1 hour, 3 minutes [ 3780 ] 1 hour, 23 minutes [ 4980 ]
        Worklog Id 14305 [ 14305 ]
        Automated transition triggered when Jonathan Reissmueller merged pull request #995 in Stash -
        Status In Review [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            tyson Tyson Phillips (Inactive)
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              23/Dec/20

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 1 hour, 23 minutes
              1h 23m

                Agile