Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-3088

Renew date change proration ignores config options

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.6.0-b1
    • Component/s: None
    • Labels:
      None

      Description

      Currently, when an admin manually changes the renew date of a service, a prorated invoice is created for only the price of the package and does not include the cost of configurable options in the calculation. To recreate:

      • Create a package for the none module with a pricing term of $1 for 1 month
      • Create a checkbox config option and group with a pricing term of $1 for 1 month attached to that package
      • Create a service using the package and add the checkbox config option, the total price will be $2
      • Manage the service and use the 'change renew date' action.
      • Set the renew date to half way between today and the renew date
      • An credit will be created for ~$0.50 which is half of the package price, rather than ~$1 which would be half of the correct $2 total

      It looks like service edit invoicing still uses package methods to calculate line items. Instead this should be changed to use the pricing presenter. Doing so would eliminate this issue.

        Activity

        jonathan Jonathan Reissmueller created issue -
        tyson Tyson Phillips (Inactive) made changes -
        Field Original Value New Value
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Sprint 4.6.0 Sprint 6 [ 81 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
        Status Open [ 1 ] In Progress [ 3 ]
        jonathan Jonathan Reissmueller made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 35 minutes [ 2100 ]
        Worklog Id 12154 [ 12154 ]
        Automated transition triggered when Jonathan Reissmueller created pull request #655 in Stash -
        Status In Progress [ 3 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]
        tyson Tyson Phillips (Inactive) made changes -
        Sprint 4.6.0 Sprint 6 [ 81 ] 4.6.0 Sprint 6, 4.6.0 Sprint 7 [ 81, 85 ]
        tyson Tyson Phillips (Inactive) made changes -
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Time Spent 35 minutes [ 2100 ] 4 hours, 6 minutes [ 14760 ]
        Worklog Id 12202 [ 12202 ]
        Automated transition triggered when Tyson Phillips (Inactive) merged pull request #655 in Stash -
        Status In Review [ 5 ] Closed [ 6 ]
        tyson Tyson Phillips (Inactive) made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        tyson Tyson Phillips (Inactive) made changes -
        Fix Version/s 4.6.0-b1 [ 11117 ]
        tyson Tyson Phillips (Inactive) made changes -
        Status Reopened [ 4 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            jonathan Jonathan Reissmueller
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              28/May/19

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 4 hours, 6 minutes
              4h 6m

                Agile