Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-3092

Addon invoices may not be prorated properly

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.6.0-b1
    • Component/s: None
    • Labels:
      None

      Description

      When creating an addon for a service, the addon may not be prorated to the parent's service renew date when it should be.

      On line 1338 a client group is fetched using a client ID. Change:

                      && ($client_group = $this->ClientGroups->get($client->id))
      

      to

                      && ($client_group = $this->ClientGroups->get($client->client_group_id))
      

        Activity

        jonathan Jonathan Reissmueller created issue -
        Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Automated transition triggered when Jonathan Reissmueller created pull request #641 in Stash -
        Status In Progress [ 3 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]
        jonathan Jonathan Reissmueller made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 8 minutes [ 480 ]
        Worklog Id 12107 [ 12107 ]
        tyson Tyson Phillips (Inactive) made changes -
        Fix Version/s 4.6.0-b1 [ 11117 ]
        tyson Tyson Phillips (Inactive) made changes -
        Description On line 1338 a client group is fetched using a client ID. Change:

        {code:java}
                        && ($client_group = $this->ClientGroups->get($client->id))
        {code}

        to

        {code:java}
                        && ($client_group = $this->ClientGroups->get($client->client_group_id))
        {code}
        When creating an addon for a service, the addon may not be prorated to the parent's service renew date when it should be.

        On line 1338 a client group is fetched using a client ID. Change:

        {code:java}
                        && ($client_group = $this->ClientGroups->get($client->id))
        {code}

        to

        {code:java}
                        && ($client_group = $this->ClientGroups->get($client->client_group_id))
        {code}
        tyson Tyson Phillips (Inactive) made changes -
        Sprint 4.6.0 Sprint 6 [ 81 ]
        tyson Tyson Phillips (Inactive) made changes -
        Rank Ranked higher
        tyson Tyson Phillips (Inactive) made changes -
        Sprint 4.6.0 Sprint 6 [ 81 ] 4.6.0 Sprint 5 [ 83 ]
        tyson Tyson Phillips (Inactive) made changes -
        Rank Ranked higher
        Automated transition triggered when Tyson Phillips (Inactive) merged pull request #641 in Stash -
        Status In Review [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            jonathan Jonathan Reissmueller
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              28/May/19

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 8 minutes
              8m

                Agile