Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 4.7.0-b1
-
Component/s: None
-
Labels:None
Description
When creating a service for a client as an admin, we list Inactive and Restricted packages. Restricted packages are disabled options unless the client has access to them. However, Inactive packages are selectable options even though they are not intended to be used. Attempting to create a service from an inactive package leads to the following error:
The client can not access that package.
- Update the package list when adding a service to disable inactive packages, similar to restricted packages
When adding a service through the admin interface, inactive packages are shown among the package options. However, after selecting that package and attempting to add the service, an error is encountered saying "The client can not access that package". We should either modify this to accept inactive packages or otherwise not list them. Probably the latter.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
| Story Points | 2 |
| Rank | Ranked lower |
Tyson Phillips (Inactive)
made changes -
| Description | When adding a service through the admin interface, inactive packages are shown among the package options. However, after selecting that package and attempting to add the service, an error is encountered saying "The client can not access that package". We should either modify this to accept inactive packages or otherwise not list them. Probably the later. |
When creating a service for a client as an admin, we list Inactive and Restricted packages. Restricted packages are disabled options unless the client has access to them. However, Inactive packages are selectable options even though they are not intended to be used. Attempting to create a service from an inactive package leads to the following error:
{quote} The client can not access that package. {quote} # Update the package list when adding a service to disable inactive packages, similar to restricted packages ---- When adding a service through the admin interface, inactive packages are shown among the package options. However, after selecting that package and attempting to add the service, an error is encountered saying "The client can not access that package". We should either modify this to accept inactive packages or otherwise not list them. Probably the latter. |
Tyson Phillips (Inactive)
made changes -
| Fix Version/s | Short Term [ 10800 ] |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.7.0 Sprint 2 [ 87 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Tyson Phillips (Inactive)
made changes -
| Fix Version/s | 4.7.0-b1 [ 11123 ] |
Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Remaining Estimate | 0 minutes [ 0 ] | |
| Time Spent | 25 minutes [ 1500 ] | |
| Worklog Id | 12420 [ 12420 ] |
Automated transition triggered when Jonathan Reissmueller created pull request #707 in Stash -
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Time Spent | 25 minutes [ 1500 ] | 35 minutes [ 2100 ] |
| Worklog Id | 12420 [ 12420 ] |
Automated transition triggered when Tyson Phillips (Inactive) merged pull request #707 in Stash -
| Status | In Review [ 5 ] | Closed [ 6 ] |
Yea, this task just greys out inactive packages like we do for restricted packages. Using restricted packages instead seems to make sense.
So it still clogs up the drop down, but can't be used. Maybe we shouldn't show inactive ones at all if they can never be used. Restricted ones are good to see, because we can see them and then give the client access, and then they can be added.. but inactive can never be added. Unless it's the current package an we're changing it. Which brings up the question.. if the client has an inactive package, will the one they have be selected?
Paul Phillips
added a comment - So it still clogs up the drop down, but can't be used. Maybe we shouldn't show inactive ones at all if they can never be used. Restricted ones are good to see, because we can see them and then give the client access, and then they can be added.. but inactive can never be added. Unless it's the current package an we're changing it. Which brings up the question.. if the client has an inactive package, will the one they have be selected? I suppose we could not display the inactive packages or we could display them below the restricted packages.
As far as which package is selected, this change affects neither the client interface nor the admin edit page. It only affects adding a service through the admin interface.
What was done here? Historically I've personally added services to clients using Inactive Packages.. typically a legacy customer on a legacy plan and they want another but cannot purchase it themselves.
On the other hand, if we always list Inactive Packages the drop down can get very long and difficult to navigate. Perhaps such a Package should just be a restricted Package instead if it needs to be used at all, but should not be available to all clients or listed under active Packages.