Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 4.6.0
-
Fix Version/s: 4.9.0-b1
-
Component/s: Client Interface, Staff Interface
-
Labels:None
Description
When using a PNG logo for invoices (JPG works fine) and generating multiple invoices in a single PDF, as with using the bulk email invoice feature on a client's profile page, the logo only appears on the first page.
Did not test whether this is also the case for single invoices that span multiple pages.
This issue remains unfixed in TCPDF, but only affects some PNG file types. If this is encountered, the PNG image should be resaved. For example, with Photoshop, you can "Save for Web" and the PNG will appear on multiple invoices.
Activity
Paul Phillips
created issue -
Tyson Phillips (Inactive)
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | 4.6.1 [ 11124 ] |
Tyson Phillips (Inactive)
made changes -
| Assignee | Jonathan Reissmueller [ jonathan ] |
Tyson Phillips (Inactive)
made changes -
| Fix Version/s | Short Term [ 10800 ] | |
| Fix Version/s | 4.7.0-b1 [ 11123 ] |
The author of TCPDF doesn't appear interested in updating the existing TCPDF library. He is going to eventually replace it with the TC-LIB-PDF library, but it is still a work in progress, so we're in a weird phase where there are no updates to the existing system but the new system is not ready to use.
Tyson Phillips (Inactive)
added a comment - The author of TCPDF doesn't appear interested in updating the existing TCPDF library. He is going to eventually replace it with the TC-LIB-PDF library , but it is still a work in progress, so we're in a weird phase where there are no updates to the existing system but the new system is not ready to use. | Remaining Estimate | 0 minutes [ 0 ] | |
| Time Spent | 5 minutes [ 300 ] | |
| Worklog Id | 12665 [ 12665 ] |
| Remaining Estimate | 0 minutes [ 0 ] | 5 minutes [ 300 ] |
| Time Spent | 5 minutes [ 300 ] | 0 minutes [ 0 ] |
| Worklog Id | 12665 [ 12665 ] | |
| Worklog Time Spent | 5 minutes [ 300 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Tyson Phillips (Inactive)
made changes -
| Fix Version/s | 4.9.0-b1 [ 11301 ] | |
| Fix Version/s | Short Term [ 10800 ] |
It looks like TCPDF has been updated in the last week to fix this, so we can retest and see if that resolves this issue for TCPDF v6.3.5.
Tyson Phillips (Inactive)
added a comment - It looks like TCPDF has been updated in the last week to fix this , so we can retest and see if that resolves this issue for TCPDF v6.3.5. Tyson Phillips (Inactive)
made changes -
| Sprint | 4.9.0 Sprint 5 [ 103 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked lower |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.9.0 Sprint 5 [ 103 ] | 4.9.0 Sprint 4 [ 102 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked higher |
| Assignee | Jonathan Reissmueller [ jonathan ] |
Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
| Status | Open [ 1 ] | In Progress [ 3 ] |
That update is not for this issue, but rather for CORE-2989
So the latest update of TCPDF does not resolve the issue with PNG logos for this task?
Tyson Phillips (Inactive)
added a comment - So the latest update of TCPDF does not resolve the issue with PNG logos for this task? The latest update does not address it, and from testing it doesn't seem that the previous updates we missed don't address it either
Looks like this update solves the issue for me
Tyson Phillips (Inactive)
added a comment - Looks like this update solves the issue for me Tyson Phillips (Inactive)
made changes -
| Description |
When using a PNG logo for invoices (JPG works fine) and generating multiple invoices in a single PDF, as with using the bulk email invoice feature on a client's profile page, the logo only appears on the first page.
Did not test whether this is also the case for single invoices that span multiple pages. |
When using a PNG logo for invoices (JPG works fine) and generating multiple invoices in a single PDF, as with using the bulk email invoice feature on a client's profile page, the logo only appears on the first page.
Did not test whether this is also the case for single invoices that span multiple pages. *This issue remains unfixed in TCPDF, but only affects some PNG file types. If this is encountered, the PNG image should be resaved. For example, with Photoshop, you can "Save for Web" and the PNG will appear on multiple invoices.* |
| Remaining Estimate | 5 minutes [ 300 ] | 0 minutes [ 0 ] |
| Time Spent | 0 minutes [ 0 ] | 15 minutes [ 900 ] |
| Worklog Id | 13214 [ 13214 ] |
Tyson Phillips (Inactive)
made changes -
| Time Spent | 15 minutes [ 900 ] | 41 minutes [ 2460 ] |
| Worklog Id | 13215 [ 13215 ] |
Automated transition triggered when Jonathan Reissmueller created pull request #799 in Stash -
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.9.0 Sprint 4 [ 102 ] | 4.9.0 Sprint 4, 4.9.0 Sprint 5 [ 102, 103 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Automated transition triggered when Tyson Phillips (Inactive) merged pull request #799 in Stash -
| Status | In Review [ 5 ] | Closed [ 6 ] |
This is a bug with TCPDF as I mentioned @ https://www.blesta.com/forums/index.php?/topic/13021-invoices-deliver-via-email-and-logo/
We should upgrade TCPDF when they fix it, but my suggestion in that thread could suffice as a work-around for the interim.