Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: 4.7.0
-
Fix Version/s: 4.7.1
-
Component/s: None
-
Labels:None
Description
Upon attempting to create an addon service through the client interface, the user receives an error
Undefined property: Services::$Clients on line 5159 in F:\wamp\www\blesta\public_html\app\models\services.php
This is due to non-robust checks when loading models used in the method. Specifically these lines:
if (!isset($this->Packages)) {
Loader::loadModels($this, ['Packages', 'Clients', 'ClientGroups']);
}
Which only check whether packages is loaded, meaning that Clients and ClientGroups may not be loaded. The check is not really even necessary since the loader takes care of this. We should probably just remove the "if" check
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
| Sprint | 4.8.0 Sprint 1 [ 92 ] |
| Rank | Ranked higher |
Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
| Status | Open [ 1 ] | In Progress [ 3 ] |
Automated transition triggered when Jonathan Reissmueller created pull request #734 in Stash -
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
Automated transition triggered when Tyson Phillips (Inactive) merged pull request #734 in Stash -
| Status | In Review [ 5 ] | Closed [ 6 ] |