[CORE-3302] Email for paying with auth/capture gateway has missing tags - Blesta

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 4.7.1
Fix Version/s: 4.7.2, 4.8.0-b1
Component/s: None
Labels:
None

Description

When making payment with a gateway the uses the authorize/capture flow, there are a couple issues. First, the GatewayPayments authorizePayment() method does not link the payment account to the transaction it creates. Second, the GatewayPayment capturePayment() method does not include the company as an email tag like the processPayment() method does.

Activity

Ascending order - Click to sort in descending order

Jonathan Reissmueller created issue - 24/Oct/19 11:32 AM

Jonathan Reissmueller made changes - 24/Oct/19 11:32 AM

Field	Original Value	New Value
Rank		Ranked higher

Hide

Permalink

Jonathan Reissmueller added a comment - 24/Oct/19 11:33 AM - edited

Possible solution given to a client.
On line of components/gateway_payments/gateway_payments.php 939 change:

        $transaction_id = $this->Transactions->add([
            'client_id' => $client_id,
            'amount' => $amount,
            'currency' => $currency,
            'type' => $type,
            'gateway_id' => $gateway->id,
            'transaction_id' => $response['transaction_id'],
            'reference_id' => isset($response['reference_id']) ? $response['reference_id'] : null,
            'status' => $response['status']
        ]);

        $transaction_id = $this->Transactions->add([
            'client_id' => $client_id,
            'amount' => $amount,
            'currency' => $currency,
            'type' => $type,
            'gateway_id' => $gateway->id,
            'account_id' => $account_id,
            'transaction_id' => $response['transaction_id'],
            'reference_id' => isset($response['reference_id']) ? $response['reference_id'] : null,
            'status' => $response['status']
       ]);

On line 1127 change :

                $tags = [
                    'contact' => $contact,
                    'amount' => $this->CurrencyFormat->format($amount, $transaction->currency),
                    'transaction_id' => $transaction->id,
                    'response' => $response,
                    'last_four' => (isset($account->last4) ? $account->last4 : null)
                ];

                $tags = [
                    'contact' => $contact,
                    'amount' => $this->CurrencyFormat->format($amount, $transaction->currency),
                    'transaction_id' => $transaction->id,
                    'response' => $response,
                    'last_four' => (isset($account->last4) ? $account->last4 : null),
                    'company' => $this->Companies->get($this->company_id)
                ];

On lines 1134-1137 change from:

                    // Set credit card specific tags
                    if ($transaction->type == 'cc' && isset($account->type)) {
                        $tags['card_type'] = Language::_('Gateways.card_types.' . $account->type, true);
                    }

                    // Set credit card specific tags
                    if ($transaction->type == 'cc' && isset($account->type)) {
                        $card_types = $this->Accounts->getCcTypes();
                        $tags['card_type'] = isset($card_types[$account->type])
                            ? $card_types[$account->type]
                            : null;
                    }

Show

Jonathan Reissmueller added a comment - 24/Oct/19 11:33 AM - edited Possible solution given to a client. On line of components/gateway_payments/gateway_payments.php 939 change: $transaction_id = $ this ->Transactions->add([ 'client_id' => $client_id, 'amount' => $amount, 'currency' => $currency, 'type' => $type, 'gateway_id' => $gateway->id, 'transaction_id' => $response['transaction_id'], 'reference_id' => isset($response['reference_id']) ? $response['reference_id'] : null , 'status' => $response['status'] ]); to $transaction_id = $ this ->Transactions->add([ 'client_id' => $client_id, 'amount' => $amount, 'currency' => $currency, 'type' => $type, 'gateway_id' => $gateway->id, 'account_id' => $account_id, 'transaction_id' => $response['transaction_id'], 'reference_id' => isset($response['reference_id']) ? $response['reference_id'] : null , 'status' => $response['status'] ]); On line 1127 change : $tags = [ 'contact' => $contact, 'amount' => $ this ->CurrencyFormat->format($amount, $transaction->currency), 'transaction_id' => $transaction->id, 'response' => $response, 'last_four' => (isset($account->last4) ? $account->last4 : null ) ]; to $tags = [ 'contact' => $contact, 'amount' => $ this ->CurrencyFormat->format($amount, $transaction->currency), 'transaction_id' => $transaction->id, 'response' => $response, 'last_four' => (isset($account->last4) ? $account->last4 : null ), 'company' => $ this ->Companies->get($ this ->company_id) ]; On lines 1134-1137 change from: // Set credit card specific tags if ($transaction->type == 'cc' && isset($account->type)) { $tags['card_type'] = Language::_('Gateways.card_types.' . $account->type, true ); } to // Set credit card specific tags if ($transaction->type == 'cc' && isset($account->type)) { $card_types = $ this ->Accounts->getCcTypes(); $tags['card_type'] = isset($card_types[$account->type]) ? $card_types[$account->type] : null ; }

Tyson Phillips (Inactive) made changes - 30/Oct/19 2:19 PM

Sprint

4.8.0 Sprint 4 [ 95 ]

Tyson Phillips (Inactive) made changes - 30/Oct/19 2:19 PM

Rank

Ranked lower

Tyson Phillips (Inactive) made changes - 12/Nov/19 4:02 PM

Rank

Ranked lower

Jonathan Reissmueller made changes - 12/Nov/19 6:26 PM

Assignee

Jonathan Reissmueller [ jonathan ]

Automated transition triggered when Jonathan Reissmueller created a branch in Stash - 12/Nov/19 6:27 PM

Status

Open [ 1 ]

In Progress [ 3 ]

Jonathan Reissmueller made changes - 13/Nov/19 11:47 AM

Remaining Estimate		0 minutes [ 0 ]
Time Spent		25 minutes [ 1500 ]
Worklog Id	12739 [ 12739 ]

Automated transition triggered when Jonathan Reissmueller created pull request #757 in Stash - 13/Nov/19 11:48 AM

Status	In Progress [ 3 ]	In Review [ 5 ]
Resolution		Fixed [ 1 ]

Automated transition triggered when Tyson Phillips (Inactive) merged pull request #757 in Stash - 13/Nov/19 2:03 PM

Status

In Review [ 5 ]

Closed [ 6 ]

People

Assignee:

Jonathan Reissmueller

Reporter:

Jonathan Reissmueller

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

24/Oct/19 11:32 AM

Updated:

13/Nov/19 2:03 PM

Resolved:

13/Nov/19 11:48 AM

Fix Release Date:

13/Nov/19

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

25m

Agile

Completed Sprint:

4.8.0 Sprint 4 ended 20/Nov/19
View on Board