Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 4.8.0-b1
-
Component/s: None
-
Labels:None
Description
To reproduce:
- Create a coupon for 100%
- Start ordering an item in the order form
- Apply 100% coupon
- Finish order and see negative invoice is created
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
| Description |
To reproduce:
- Create a coupon for 100% - Start ordering an item in the order form - Apply 100% coupon - Finish order and see negative invoice is created This does not happen in the admin interface |
To reproduce:
- Create a coupon for 100% - Start ordering an item in the order form - Apply 100% coupon - Finish order and see negative invoice is created |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.8.0 Sprint 5 [ 96 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Tyson Phillips (Inactive)
made changes -
| Fix Version/s | 4.8.0-b1 [ 11127 ] |
| Assignee | Jonathan Reissmueller [ jonathan ] |
Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
| Status | Open [ 1 ] | In Progress [ 3 ] |
Automated transition triggered when Jonathan Reissmueller created pull request #764 in Stash -
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Remaining Estimate | 0 minutes [ 0 ] | |
| Time Spent | 40 minutes [ 2400 ] | |
| Worklog Id | 12762 [ 12762 ] |
If some line items are not taxable (e.g. setup fees), then this will still result in a negative invoice. Additionally, any proration that occurs may also cause a positive or negative value on a 100% coupon because the sum of the rounded line item prices may be slightly above or below the rounded coupon amount.
I don't see a suitable way to avoid this behavior without integrating updates to the way invoice data is stored. That is, tax rules would need to be stored for each line item and the amounts would have to rounded to the currency's precision prior to storage.
Tyson Phillips (Inactive)
added a comment - If some line items are not taxable (e.g. setup fees), then this will still result in a negative invoice. Additionally, any proration that occurs may also cause a positive or negative value on a 100% coupon because the sum of the rounded line item prices may be slightly above or below the rounded coupon amount.
I don't see a suitable way to avoid this behavior without integrating updates to the way invoice data is stored. That is, tax rules would need to be stored for each line item and the amounts would have to rounded to the currency's precision prior to storage.
Automated transition triggered when Tyson Phillips (Inactive) merged pull request #764 in Stash -
| Status | In Review [ 5 ] | Closed [ 6 ] |
Looks like this is caused by a package not being taxable. Tax will be applied to the coupon but not the service.