Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-3374

TheSSLStore: Errors encountered when unable to connect via the API

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 4.8.0
        • Component/s: Modules
        • Labels:
          None

          Description

          TheSSLStore module performs some requests with the API, but returns the wrong expected type if the API cannot connect successfully.

          For example, if the API credentials are invalid, but you try to create a new package, when you choose the SSLStore from the list, the module options will fail to load due to an error:

          Invalid argument supplied for foreach() on line 1677 in /components/modules/thesslstore_module/thesslstore_module.php

          This has to do with an attempt to fetch products via the API. The API had no response (i.e. null). The expected return value of "getProducts" is an array, but it returned null.

          Glancing at the module, each of these methods are affected by this behavior:

          • getProducts
          • parseResponse
          • validateCSR

            Activity

            Ascending order - Click to sort in descending order
            tyson Tyson Phillips (Inactive) created issue -
            tyson Tyson Phillips (Inactive) made changes -
            Field Original Value New Value
            Rank Ranked higher
            tyson Tyson Phillips (Inactive) made changes -
            Sprint 4.9.0 Sprint 1 [ 98 ]
            tyson Tyson Phillips (Inactive) made changes -
            Rank Ranked lower
            tyson Tyson Phillips (Inactive) made changes -
            Issue Type Improvement [ 4 ] Bug [ 1 ]
            jonathan Jonathan Reissmueller made changes -
            Assignee Jonathan Reissmueller [ jonathan ]
            jonathan Jonathan Reissmueller made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            jonathan Jonathan Reissmueller made changes -
            Remaining Estimate 0 minutes [ 0 ]
            Time Spent 1 hour, 18 minutes [ 4680 ]
            Worklog Id 12967 [ 12967 ]
            jonathan Jonathan Reissmueller made changes -
            Status In Progress [ 3 ] In Review [ 5 ]
            Resolution Fixed [ 1 ]
            tyson Tyson Phillips (Inactive) made changes -
            Status In Review [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                jonathan Jonathan Reissmueller
                Reporter:
                tyson Tyson Phillips (Inactive)
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 18 minutes
                  1h 18m

                    Agile