Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-3377

Pterodactyl: Egg variable rule parsing is not robust enough

        Details

        • Type: Bug
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 4.8.0-b1
        • Fix Version/s: 4.8.0
        • Component/s: None
        • Labels:
          None

          Description

          In an attempt to mitigate errors in server creation, we decided to pull in and parse egg variable validation rules. The parsing does not handle some use cases well.

          Specifically we try to split up rules and arguments by characters like "|", ":", and ",". These characters may be a part of an argument though, for example in a regex. We need to find a better way of parsing that can handle these.

            Activity

            Ascending order - Click to sort in descending order
            jonathan Jonathan Reissmueller created issue -
            jonathan Jonathan Reissmueller made changes -
            Field Original Value New Value
            Rank Ranked higher
            jonathan Jonathan Reissmueller made changes -
            Remaining Estimate 0 minutes [ 0 ]
            Time Spent 1 hour, 30 minutes [ 5400 ]
            Worklog Id 12970 [ 12970 ]
            jonathan Jonathan Reissmueller made changes -
            Status Open [ 1 ] In Review [ 5 ]
            Resolution Fixed [ 1 ]
            tyson Tyson Phillips (Inactive) made changes -
            Sprint 4.9.0 Sprint 1 [ 98 ]
            tyson Tyson Phillips (Inactive) made changes -
            Rank Ranked higher
            tyson Tyson Phillips (Inactive) made changes -
            Status In Review [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                jonathan Jonathan Reissmueller
                Reporter:
                jonathan Jonathan Reissmueller
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  13/Jan/20

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 hour, 30 minutes
                  1h 30m

                    Agile