Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 4.9.0-b1
-
Component/s: Staff Interface
-
Labels:None
Description
When upgrading a plugin via the Staff UI, it's possible that the upgraded plugins added new actions to the navigation. However, they will not appear after an upgrade. The staff groups would have to be re-saved in the UI for this to occur.
Instead, we should update the system to clear the cache any time a plugin is upgraded via the UI. Ideally, the navigation should be cleared for every company the plugin is apart of.
This probably should occur from the controller where the action is performed rather than PluginManager::upgrade since that method is called via the Blesta upgrade script as well, which already clears the navigation cache afterward.
It would also be great if we could abstract this cross-cutting functionality into a new /core/ class that can be used to replace all existing locations where we perform similar cache clearing for the nav.
Activity
Tyson Phillips (Inactive)
created issue -
Tyson Phillips (Inactive)
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
Tyson Phillips (Inactive)
made changes -
| Story Points | 2 |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.9.0 Sprint 5 [ 103 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked lower |
Tyson Phillips (Inactive)
made changes -
| Description |
When upgrading a plugin via the Staff UI, it's possible that the upgraded plugins added new actions to the navigation. However, they will not appear after an upgrade. The staff groups would have to be re-saved in the UI for this to occur.
Instead, we should update the system to clear the cache any time a plugin is upgraded via the UI. Ideally, the navigation should be cleared for every company the plugin is apart of. This probably should occur from the controller where the action is performed rather than _PluginManager::upgrade_ since that method is called via the Blesta upgrade script as well, which already clears the navigation cache afterward. |
When upgrading a plugin via the Staff UI, it's possible that the upgraded plugins added new actions to the navigation. However, they will not appear after an upgrade. The staff groups would have to be re-saved in the UI for this to occur.
Instead, we should update the system to clear the cache any time a plugin is upgraded via the UI. Ideally, the navigation should be cleared for every company the plugin is apart of. This probably should occur from the controller where the action is performed rather than _PluginManager::upgrade_ since that method is called via the Blesta upgrade script as well, which already clears the navigation cache afterward. It would also be great if we could abstract this cross-cutting functionality into a new /core/ class that can be used to replace all existing locations where we perform similar cache clearing for the nav. |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.9.0 Sprint 5 [ 103 ] |
Tyson Phillips (Inactive)
made changes -
| Rank | Ranked higher |
Tyson Phillips (Inactive)
made changes -
| Sprint | 4.9.0 Sprint 6 [ 104 ] |
Tyson Phillips (Inactive)
made changes -
| Assignee | Tyson Phillips [ tyson ] |
Tyson Phillips (Inactive)
made changes -
| Status | Open [ 1 ] | In Progress [ 3 ] |
Automated transition triggered when Tyson Phillips (Inactive) created pull request #808 in Stash -
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
Tyson Phillips (Inactive)
made changes -
| Remaining Estimate | 0 minutes [ 0 ] | |
| Time Spent | 1 hour, 16 minutes [ 4560 ] | |
| Worklog Id | 13284 [ 13284 ] |
Automated transition triggered when Tyson Phillips (Inactive) merged pull request #808 in Stash -
| Status | In Review [ 5 ] | Closed [ 6 ] |
