Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-3623

Import Manager: More WHMCS import improvments

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.10.0
    • Component/s: None
    • Labels:
      None

      Description

      Issue #1: Recurring invoice import may cause fatal error if invoice lines are assigned to an invoice that doesn't exist. Add a sanity check on line 710 of whmcs_migrator:

                          if (!isset($this->mappings['invoices'][$line->invoiceid])) {
                              continue;
                          }
      

      Issue #2: Ticket import violates full_group_by select rules by selecting a non-aggregate field that doesn't exist in the grouping clause.

        Activity

        jonathan Jonathan Reissmueller created issue -
        Automated transition triggered when Jonathan Reissmueller created a branch in Stash -
        Field Original Value New Value
        Status Open [ 1 ] In Progress [ 3 ]
        Automated transition triggered when Jonathan Reissmueller created pull request #18 in Stash -
        Status In Progress [ 3 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]
        jonathan Jonathan Reissmueller made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 30 minutes [ 1800 ]
        Worklog Id 13658 [ 13658 ]
        jonathan Jonathan Reissmueller made changes -
        Sprint 4.11.0 Sprint 2 [ 109 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        abdy Abdy Franco made changes -
        Time Spent 30 minutes [ 1800 ] 1 hour, 17 minutes [ 4620 ]
        Worklog Id 13660 [ 13660 ]
        Automated transition triggered when Jonathan Reissmueller merged pull request #18 in Stash -
        Status In Review [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            jonathan Jonathan Reissmueller
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              26/May/20

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 1 hour, 17 minutes
              1h 17m

                Agile