Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-4087

Order: Affiliate activation adds link to primary staff nav

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.0.0-b1
    • Component/s: None
    • Labels:
      None

      Description

      AdminAffiliates::enableAffiliateActions() adds items using the action and navigation models. One of these items is the affiliates link for admin nav menu which should be a subitem under the Clients nav item. Instead it is being added as a primary item. It should really just be skipped anyway since it already exists. Change:

                      if ($action->action == 'nav_secondary_staff') {
                          $nav_vars = ['parent_url' => 'clients/'];
                      }
      

      To

                      if ($action->action == 'nav_staff') {
                          continue;
                      }
      

        Activity

        jonathan Jonathan Reissmueller created issue -
        jonathan Jonathan Reissmueller made changes -
        Field Original Value New Value
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Sprint 5.0.0 Sprint 6 [ 123 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked lower
        jonathan Jonathan Reissmueller made changes -
        Assignee Jonathan Reissmueller [ jonathan ]
        jonathan Jonathan Reissmueller made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        jonathan Jonathan Reissmueller made changes -
        Description AdminAffiliates::enableAffiliateActions() adds items using the action and navigation models. One of these items is the affiliates link for admin nav menu which should be a subitem under the Clients nav item. Instead it is being added as a primary item. It should really just be skipped anyway since it already exists. Change:


        {code:java}
                        if ($action->action == 'nav_secondary_staff') {
                            $nav_vars = ['parent_url' => 'clients/'];
                        }
        {code}
        To

        {code:java}
                        if ($action->action == 'nav_secondary_staff') {
                            continue;
                        }
        {code}

        AdminAffiliates::enableAffiliateActions() adds items using the action and navigation models. One of these items is the affiliates link for admin nav menu which should be a subitem under the Clients nav item. Instead it is being added as a primary item. It should really just be skipped anyway since it already exists. Change:


        {code:java}
                        if ($action->action == 'nav_secondary_staff') {
                            $nav_vars = ['parent_url' => 'clients/'];
                        }
        {code}
        To

        {code:java}
                        if ($action->action == 'nav_staff') {
                            continue;
                        }
        {code}

        jonathan Jonathan Reissmueller made changes -
        Status In Progress [ 3 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]
        jonathan Jonathan Reissmueller made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 14 minutes [ 840 ]
        Worklog Id 14627 [ 14627 ]
        abdy Abdy Franco made changes -
        Status In Review [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            jonathan Jonathan Reissmueller
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              23/Dec/20

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 14 minutes
              14m

                Agile