Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 5.0.0
-
Fix Version/s: 5.0.3
-
Component/s: None
-
Labels:None
Description
Currently, when a multi-company installation is upgraded (at least from 4.12.3 to 5.0.2), actions for the current company will be added/updated fine, while those from other companies will be erase. This results in missing nav items and widgets.
Steps to reproduce:
- Install with 4.12.3
- Add additional company
- Install plugin on additional company
- Run upgrade via cli
- Login to admin interface and switch to additional company
- See that nav items are missing
It seems this is caused by PluginManager::convertOldActionParams() and PluginManager::get(). convertOldActionParams() calls get to retrieve a company ID from the fetched plugin, but get() will only fetch a plugin for the current company.
I can think of 2 solutions off the top of my head:
- Find another way for convertOldActionParams to get the company_id for a plugin
- Update get() to fetch plugins from any company
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
| Sprint | 5.0.3 Sprint 1 [ 130 ] |
| Rank | Ranked higher |
| Remaining Estimate | 0 minutes [ 0 ] | |
| Time Spent | 6 hours [ 21600 ] | |
| Worklog Id | 14739 [ 14739 ] |
| Time Spent | 6 hours [ 21600 ] | 6 hours, 32 minutes [ 23520 ] |
| Worklog Id | 14743 [ 14743 ] |
| Status | Open [ 1 ] | In Review [ 5 ] |
| Assignee | Jonathan Reissmueller [ jonathan ] | |
| Resolution | Fixed [ 1 ] |
| Status | In Review [ 5 ] | Closed [ 6 ] |
| Resolution | Fixed [ 1 ] | |
| Status | Closed [ 6 ] | Reopened [ 4 ] |
| Status | Reopened [ 4 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Status | In Review [ 5 ] | Closed [ 6 ] |
