[CORE-4174] Vat reverse charge adds 0% tax line items - Blesta

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: 5.0.0
Fix Version/s: 5.0.4
Component/s: None
Labels:
None

Description

Forum post: https://www.blesta.com/forums/index.php?/topic/15184-invoice-shows-wrong-tax-percentage/

To reproduce:

Enable vat tax in settings
Make sure at least one tax rule exists
Add customer with valid VATIN for tax exemption
Create a service for the client
View the invoice and see that lines with %0 are included

To resolve change components/invoice_templates/default_invoice/default_invoice_pdf.php starting at line 447 from:

            $tax_rules = $this->Invoices->getTaxRules($this->invoice->client_id);

            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('DefaultInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('DefaultInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }

            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('DefaultInvoice.tax_note_reverse_charge', true);

components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php line 682 from:

            $tax_rules = $this->Invoices->getTaxRules($this->invoice->client_id);

            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('PerforatedInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('PerforatedInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }

            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('PerforatedInvoice.tax_note_reverse_charge', true);

components/invoice_templates/quickbooks_invoice/quickbooks_invoice_pdf.php line 477 from:

            $tax_rules = $this->Invoices->getTaxRules($this->invoice->client_id);

            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('QuickbooksInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('QuickbooksInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }

            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('QuickbooksInvoice.tax_note_reverse_charge', true);

Activity

Ascending order - Click to sort in descending order

Jonathan Reissmueller created issue - 22/Feb/21 5:50 PM

Jonathan Reissmueller made changes - 22/Feb/21 5:50 PM

Field	Original Value	New Value
Rank		Ranked higher

Jonathan Reissmueller made changes - 22/Feb/21 5:51 PM

Description

Forum post: https://www.blesta.com/forums/index.php?/topic/15184-invoice-shows-wrong-tax-percentage/

To reproduce:
* Enable vat tax in settings
* Make sure at least one tax rule exists
* Add customer with valid VATIN for tax exemption
* Create a service for the client
* View the invoice and see that lines with %0 are included

To resolve change components/invoice_templates/default_invoice/default_invoice_pdf.php starting at line 449 from:

{code:java}
            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('DefaultInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('DefaultInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }
{code}
to

{code:java}
            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('DefaultInvoice.tax_note_reverse_charge', true);
{code}
components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php line 666 from:

{code:java}
            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('PerforatedInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('PerforatedInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }
{code}
to

{code:java}
            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('PerforatedInvoice.tax_note_reverse_charge', true);
{code}
components/invoice_templates/quickbooks_invoice/quickbooks_invoice_pdf.php line 461 from:

{code:java}
            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('QuickbooksInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('QuickbooksInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }
{code}
to

{code:java}
            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('QuickbooksInvoice.tax_note_reverse_charge', true);
{code}

Forum post: https://www.blesta.com/forums/index.php?/topic/15184-invoice-shows-wrong-tax-percentage/

To reproduce:
* Enable vat tax in settings
* Make sure at least one tax rule exists
* Add customer with valid VATIN for tax exemption
* Create a service for the client
* View the invoice and see that lines with %0 are included

To resolve change components/invoice_templates/default_invoice/default_invoice_pdf.php starting at line 449 from:

{code:java}
            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('DefaultInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('DefaultInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }
{code}
to

{code:java}
            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('DefaultInvoice.tax_note_reverse_charge', true);
{code}
components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php line 684 from:

{code:java}
            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('PerforatedInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('PerforatedInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }
{code}
to

{code:java}
            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('PerforatedInvoice.tax_note_reverse_charge', true);
{code}
components/invoice_templates/quickbooks_invoice/quickbooks_invoice_pdf.php line 479 from:

{code:java}
            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('QuickbooksInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('QuickbooksInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }
{code}
to

{code:java}
            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('QuickbooksInvoice.tax_note_reverse_charge', true);
{code}

Jonathan Reissmueller made changes - 22/Feb/21 6:55 PM

Description

Forum post: https://www.blesta.com/forums/index.php?/topic/15184-invoice-shows-wrong-tax-percentage/

To reproduce:
* Enable vat tax in settings
* Make sure at least one tax rule exists
* Add customer with valid VATIN for tax exemption
* Create a service for the client
* View the invoice and see that lines with %0 are included

To resolve change components/invoice_templates/default_invoice/default_invoice_pdf.php starting at line 449 from:

{code:java}
            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('DefaultInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('DefaultInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }
{code}
to

{code:java}
            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('DefaultInvoice.tax_note_reverse_charge', true);
{code}
components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php line 684 from:

{code:java}
            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('PerforatedInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('PerforatedInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }
{code}
to

{code:java}
            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('PerforatedInvoice.tax_note_reverse_charge', true);
{code}
components/invoice_templates/quickbooks_invoice/quickbooks_invoice_pdf.php line 479 from:

{code:java}
            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('QuickbooksInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('QuickbooksInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }
{code}
to

{code:java}
            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('QuickbooksInvoice.tax_note_reverse_charge', true);
{code}

Forum post: https://www.blesta.com/forums/index.php?/topic/15184-invoice-shows-wrong-tax-percentage/

To reproduce:
* Enable vat tax in settings
* Make sure at least one tax rule exists
* Add customer with valid VATIN for tax exemption
* Create a service for the client
* View the invoice and see that lines with %0 are included

To resolve change components/invoice_templates/default_invoice/default_invoice_pdf.php starting at line 447 from:

{code:java}
            $tax_rules = $this->Invoices->getTaxRules($this->invoice->client_id);

            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('DefaultInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('DefaultInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }
{code}
to

{code:java}
            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('DefaultInvoice.tax_note_reverse_charge', true);
{code}
components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php line 682 from:

{code:java}
            $tax_rules = $this->Invoices->getTaxRules($this->invoice->client_id);

            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('PerforatedInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('PerforatedInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }
{code}
to

{code:java}
            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('PerforatedInvoice.tax_note_reverse_charge', true);
{code}
components/invoice_templates/quickbooks_invoice/quickbooks_invoice_pdf.php line 477 from:

{code:java}
            $tax_rules = $this->Invoices->getTaxRules($this->invoice->client_id);

            foreach ($tax_rules as $tax) {
                $data[] = [
                    'notes' => Language::_('QuickbooksInvoice.tax_note_reverse_charge', true),
                    'label' => Language::_('QuickbooksInvoice.tax_heading', true, $tax->name, 0),
                    'price' => $this->CurrencyFormat->format(0, $this->invoice->currency)
                ];
            }
{code}
to

{code:java}
            $this->meta['terms'] .= (empty($this->meta['terms']) ? '' : "\n\n")
                . Language::_('QuickbooksInvoice.tax_note_reverse_charge', true);
{code}

Jonathan Reissmueller made changes - 23/Feb/21 3:32 PM

Sprint

5.1.0 Sprint 2 [ 126 ]

Jonathan Reissmueller made changes - 23/Feb/21 3:32 PM

Rank

Ranked higher

Jonathan Reissmueller made changes - 23/Feb/21 4:52 PM

Assignee

Jonathan Reissmueller [ jonathan ]

Jonathan Reissmueller made changes - 24/Feb/21 11:23 AM

Status	Open [ 1 ]	In Review [ 5 ]
Assignee		Jonathan Reissmueller [ jonathan ]
Resolution		Fixed [ 1 ]

Jonathan Reissmueller made changes - 18/Mar/21 10:37 AM

Status

In Review [ 5 ]

Closed [ 6 ]

People

Assignee:

Jonathan Reissmueller

Reporter:

Jonathan Reissmueller

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

22/Feb/21 5:50 PM

Updated:

18/Mar/21 10:37 AM

Resolved:

24/Feb/21 11:23 AM

Fix Release Date:

5/Apr/21

Agile

Completed Sprint:

5.1.0 Sprint 2 ended 25/Mar/21
View on Board