Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 5.1.0-b1
-
Fix Version/s: 5.1.0
-
Component/s: None
-
Labels:None
Description
When generating a confirmation modal, we call either the admin_dialog controller or the client_dialog controller. However, there is no dialog controller that can be call via the public URI. This is a problem because we recently moved plugin nav item URLs from the client URI to the public URI which may break some existing confirmation modals.
We should add a public dialog controller.
To reproduce the broken dialog edit plugins/support_manager/views/default/client_tickets.pdt and change
base_url: '<?php echo (isset($this->client_uri) ? $this->Html->safe($this->client_uri) : null);?>',
To
base_url: '<?php echo (isset($this->base_uri) ? $this->Html->safe($this->base_uri) : null);?>',
Then login as a client, visit /plugin/support_manager/client_tickets/, and try to close a ticket.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
| Sprint | 5.2.0 Sprint 1 [ 137 ] |
| Rank | Ranked lower |
| Rank | Ranked higher |
| Assignee | Jonathan Reissmueller [ jonathan ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Description |
When generating a confirmation modal, we call either the admin_dialog controller or the client_dialog controller. However, there is no dialog controller that can be call via the public URI. This is a problem because we recently moved plugin nav item URLs from the client URI to the public URI which may break some existing confirmation modals.
We should add a public dialog controller. |
When generating a confirmation modal, we call either the admin_dialog controller or the client_dialog controller. However, there is no dialog controller that can be call via the public URI. This is a problem because we recently moved plugin nav item URLs from the client URI to the public URI which may break some existing confirmation modals.
We should add a public dialog controller. To reproduce the broken dialog edit plugins/support_manager/views/default/client_tickets.pdt and change {code:java} base_url: '<?php echo (isset($this->client_uri) ? $this->Html->safe($this->client_uri) : null);?>', {code} To {code:java} base_url: '<?php echo (isset($this->base_uri) ? $this->Html->safe($this->base_uri) : null);?>', {code} Then login as a client, visit /plugin/support_manager/client_tickets/, and try to cancel a ticket. |
| Description |
When generating a confirmation modal, we call either the admin_dialog controller or the client_dialog controller. However, there is no dialog controller that can be call via the public URI. This is a problem because we recently moved plugin nav item URLs from the client URI to the public URI which may break some existing confirmation modals.
We should add a public dialog controller. To reproduce the broken dialog edit plugins/support_manager/views/default/client_tickets.pdt and change {code:java} base_url: '<?php echo (isset($this->client_uri) ? $this->Html->safe($this->client_uri) : null);?>', {code} To {code:java} base_url: '<?php echo (isset($this->base_uri) ? $this->Html->safe($this->base_uri) : null);?>', {code} Then login as a client, visit /plugin/support_manager/client_tickets/, and try to cancel a ticket. |
When generating a confirmation modal, we call either the admin_dialog controller or the client_dialog controller. However, there is no dialog controller that can be call via the public URI. This is a problem because we recently moved plugin nav item URLs from the client URI to the public URI which may break some existing confirmation modals.
We should add a public dialog controller. To reproduce the broken dialog edit plugins/support_manager/views/default/client_tickets.pdt and change {code:java} base_url: '<?php echo (isset($this->client_uri) ? $this->Html->safe($this->client_uri) : null);?>', {code} To {code:java} base_url: '<?php echo (isset($this->base_uri) ? $this->Html->safe($this->base_uri) : null);?>', {code} Then login as a client, visit /plugin/support_manager/client_tickets/, and try to close a ticket. |
| Remaining Estimate | 0 minutes [ 0 ] | |
| Time Spent | 20 minutes [ 1200 ] | |
| Worklog Id | 15079 [ 15079 ] |
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Time Spent | 20 minutes [ 1200 ] | 32 minutes [ 1920 ] |
| Worklog Id | 15082 [ 15082 ] |
| Status | In Review [ 5 ] | Closed [ 6 ] |
