Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-4371

Override price preview does currency conversion wrong

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.0.4
    • Fix Version/s: 5.1.1
    • Component/s: None
    • Labels:
      None

      Description

      CORE-4175 attempted a fix and failed because it used a wrong understanding of exchange rates. It assumes that an exchange rate of .5 means that the currency has a value .5 that of a USD. In reality, a .5 exchange rate means that a USD is worth .5 of the currency.

      To reproduce:

      • Create a currency with an exchange rate of 2
      • Create a service with a USD pricing
      • Edit the service
      • Select the 2 currency as the override currency and set the override price to twice that of the current price
      • Look at the totals preview box and see that instead of 0 it shows a price roughly 3 times that of the package price

      This task should simply revert the changes from CORE-4175, while CORE-4378 should implement correct currency conversion

        Activity

        jonathan Jonathan Reissmueller created issue -
        jonathan Jonathan Reissmueller made changes -
        Field Original Value New Value
        Assignee Jonathan Reissmueller [ jonathan ]
        jonathan Jonathan Reissmueller made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        jonathan Jonathan Reissmueller made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 1 hour, 10 minutes [ 4200 ]
        Worklog Id 15107 [ 15107 ]
        jonathan Jonathan Reissmueller made changes -
        Assignee Jonathan Reissmueller [ jonathan ]
        jonathan Jonathan Reissmueller made changes -
        Sprint 5.2.0 Sprint 2 [ 135 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Assignee Jonathan Reissmueller [ jonathan ]
        jonathan Jonathan Reissmueller made changes -
        Fix Version/s 5.2.0-b1 [ 11709 ]
        jonathan Jonathan Reissmueller made changes -
        Time Spent 1 hour, 10 minutes [ 4200 ] 1 hour, 27 minutes [ 5220 ]
        Worklog Id 15120 [ 15120 ]
        jonathan Jonathan Reissmueller made changes -
        Description CORE-4175 attempted a fix and failed because it used a wrong understanding of exchange rates. It assumes that an exchange rate of .5 means that the currency has a value .5 that of a USD. In reality, a .5 exchange rate means that a USD is worth .5 of the currency.

        To reproduce:
        * Create a currency with an exchange rate of 2
        * Create a service with a USD pricing
        * Edit the service
        * Select the 2 currency as the override currency and set the override price to twice that of the current price
        * Look at the totals preview box and see that instead of 0 it shows a price roughly 3 times that of the package price
        CORE-4175 attempted a fix and failed because it used a wrong understanding of exchange rates. It assumes that an exchange rate of .5 means that the currency has a value .5 that of a USD. In reality, a .5 exchange rate means that a USD is worth .5 of the currency.

        To reproduce:
        * Create a currency with an exchange rate of 2
        * Create a service with a USD pricing
        * Edit the service
        * Select the 2 currency as the override currency and set the override price to twice that of the current price
        * Look at the totals preview box and see that instead of 0 it shows a price roughly 3 times that of the package price

        This task should simply revert the changes from CORE-4175, while CORE-4378 should implement correct currency conversion
        Fix Version/s 5.2.0-b1 [ 11709 ]
        Original Estimate 0 minutes [ 0 ]
        jonathan Jonathan Reissmueller made changes -
        Status In Progress [ 3 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            jonathan Jonathan Reissmueller
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              11/Jul/21

              Time Tracking

              Estimated:
              Original Estimate - 0 minutes
              0m
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 1 hour, 27 minutes
              1h 27m

                Agile