Details
-
Type: Bug
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: 5.1.0
-
Fix Version/s: 5.1.1
-
Component/s: None
-
Labels:None
Description
To reproduce:
- Install 5.1
- Uninstall the domain manager
- Create a None module package
- Attempt to create a service in the admin interface
- Receive error
[2021-07-08T15:24:45.756300+00:00] general.ERROR: PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'blesta51.domains_tlds' doesn't exist in blesta\vendors\minphp\db\src\PdoConnection.php:196 Stack trace: #0 blesta\vendors\minphp\db\src\PdoConnection.php(196): PDOStatement->execute(Array) #1 blesta\vendors\minphp\record\src\Record.php(793): Minphp\Db\PdoConnection->query('SELECT `domains...', Array) #2 blesta\plugins\domains\models\domains_tlds.php(152): Minphp\Record\Record->fetch() #3 blesta\core\Pricing\Presenter\Items\Service\ServiceDataItems.php(139): DomainsTlds->getByPackage('5') #4 blesta\core\Pricing\Presenter\Items\Service\ServiceDataItems.php(34): Blesta\Core\Pricing\Presenter\Items\Service\ServiceDataItems->makeItems(Object(Blesta\Items\Item\Item), Object(Blesta\Items\Item\Item), Object(Blesta\Items\Item\Item)) #5 blesta\core\Pricing\Presenter\Build\ServiceData\ServiceDataBuilder.php(100): Blesta\Core\Pricing\Presenter\Items\Service\ServiceDataItems->build(Object(Blesta\Items\Item\Item), Object(Blesta\Items\Item\Item), Object(Blesta\Items\Item\Item), Object(Blesta\Items\Collection\ItemCollection)) #6 blesta\app\models\services.php(3758): Blesta\Core\Pricing\Presenter\Build\ServiceData\ServiceDataBuilder->build(Array, Object(stdClass), Object(stdClass), Array) #7 blesta\app\models\services.php(3806): Services->getDataPresenter('1', Array, Array) #8 blesta\app\controllers\admin_clients.php(7322): Services->getServiceItems(Array, Array, Array, 'USD') #9 blesta\app\controllers\admin_clients.php(5401): AdminClients->renderServiceStep('confirm', Object(stdClass), Object(stdClass), Object(stdClass)) #10 blesta\vendors\minphp\bridge\src\Lib\Dispatcher.php(142): AdminClients->addService() #11 blesta\index.php(21): Dispatcher::dispatch('/blesta51/admin...') #12 {main}
Ideally, the core should never be specifically aware of the Domain Manager. Doing so prevents dependency issues like this and is more in line with the modular philosophy of Blesta.