[CORE-4437] Import Manager: Payment account defaults are wrong - Blesta

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 5.1.3, 5.2.0-b1
Component/s: None
Labels:
None

Description

The current default for imported cc details are problematic. For example, the default for "first_name" is null, but that is an invalid value.

In import_manager/components/migrators/whmcs/8.0/whmcs8_0.php change the code starting at line 600 from

                    // Save card
                    $card = [
                        'contact_id' => $this->mappings['primary_contacts'][$credit_card->client_id],
                        'first_name' => $credit_card->{$mapping['accounts_cc']['first_name']} ?: null,
                        'last_name' => $credit_card->{$mapping['accounts_cc']['last_name']} ?: null,
                        'address1' => $credit_card->{$mapping['accounts_cc']['address1']} ?: null,
                        'address2' => $credit_card->{$mapping['accounts_cc']['address2']} ?: null,
                        'state' => !empty($credit_card->{$mapping['accounts_cc']['state']})
                            ? substr($credit_card->{$mapping['accounts_cc']['state']}, 0, 2)
                            : 'XX',
                        'city' => $credit_card->{$mapping['accounts_cc']['city']} ?: null,
                        'zip' => $credit_card->{$mapping['accounts_cc']['zip']} ?: '00000',
                        'country' => $credit_card->{$mapping['accounts_cc']['country']} ?: null,
                        'number' => isset($credit_card->{$mapping['accounts_cc']['number']})
                            ? $this->GatewayManager->systemEncrypt(
                                $credit_card->{$mapping['accounts_cc']['number']}
                            )
                            : null,
                        'expiration' => isset($credit_card->{$mapping['accounts_cc']['expiration']})
                            ? $this->GatewayManager->systemEncrypt(
                                date('Ym', strtotime($credit_card->{$mapping['accounts_cc']['expiration']}))
                            )
                            : null,
                        'last4' => isset($credit_card->{$mapping['accounts_cc']['last4']})
                            ? $this->GatewayManager->systemEncrypt(
                                $credit_card->{$mapping['accounts_cc']['last4']}
                            )
                            : null,
                        'type' => isset($credit_card->{$mapping['accounts_cc']['type']})
                            ? $this->getCreditCardType($credit_card->{$mapping['accounts_cc']['type']})
                            : 'other',
                        'gateway_id' => $gateway_id,
                        'client_reference_id' => $credit_card->{$mapping['accounts_cc']['client_reference_id']} ?: null,
                        'reference_id' => $credit_card->{$mapping['accounts_cc']['reference_id']} ?: null,
                        'status' => 'active'
                    ];

                    // Save card
                    $card = [
                        'contact_id' => $this->mappings['primary_contacts'][$credit_card->client_id],
                        'first_name' => $credit_card->{$mapping['accounts_cc']['first_name']} ?? $this->default_firstname,
                        'last_name' => $credit_card->{$mapping['accounts_cc']['last_name']} ?? $this->default_lastname,
                        'address1' => $credit_card->{$mapping['accounts_cc']['address1']} ?? '',
                        'address2' => $credit_card->{$mapping['accounts_cc']['address2']} ?? null,
                        'state' => !empty($credit_card->{$mapping['accounts_cc']['state']})
                            ? substr($credit_card->{$mapping['accounts_cc']['state']}, 0, 2)
                            : 'XX',
                        'city' => $credit_card->{$mapping['accounts_cc']['city']} ?? '',
                        'zip' => $credit_card->{$mapping['accounts_cc']['zip']} ?? '00000',
                        'country' => $credit_card->{$mapping['accounts_cc']['country']} ?? $this->default_country,
                        'number' => isset($credit_card->{$mapping['accounts_cc']['number']})
                            ? $this->GatewayManager->systemEncrypt(
                                $credit_card->{$mapping['accounts_cc']['number']}
                            )
                            : null,
                        'expiration' => isset($credit_card->{$mapping['accounts_cc']['expiration']})
                            ? $this->GatewayManager->systemEncrypt(
                                date('Ym', strtotime($credit_card->{$mapping['accounts_cc']['expiration']}))
                            )
                            : null,
                        'last4' => isset($credit_card->{$mapping['accounts_cc']['last4']})
                            ? $this->GatewayManager->systemEncrypt(
                                $credit_card->{$mapping['accounts_cc']['last4']}
                            )
                            : null,
                        'type' => isset($credit_card->{$mapping['accounts_cc']['type']})
                            ? $this->getCreditCardType($credit_card->{$mapping['accounts_cc']['type']})
                            : 'other',
                        'gateway_id' => $gateway_id,
                        'client_reference_id' => $credit_card->{$mapping['accounts_cc']['client_reference_id']} ?? null,
                        'reference_id' => $credit_card->{$mapping['accounts_cc']['reference_id']} ?? null,
                        'status' => 'active'
                    ];

Activity

Ascending order - Click to sort in descending order

Jonathan Reissmueller created issue - 09/Aug/21 11:35 AM

Jonathan Reissmueller made changes - 09/Aug/21 11:35 AM

Field	Original Value	New Value
Rank		Ranked higher

Jonathan Reissmueller made changes - 09/Aug/21 11:35 AM

Sprint

5.2.0 Sprint 3 [ 140 ]

Jonathan Reissmueller made changes - 09/Aug/21 11:35 AM

Rank

Ranked lower

Jonathan Reissmueller made changes - 09/Aug/21 11:35 AM

Rank

Ranked higher

Abdy Franco made changes - 09/Aug/21 3:06 PM

Assignee

Abdy Franco [ abdy ]

Abdy Franco made changes - 09/Aug/21 3:06 PM

Status

Open [ 1 ]

In Progress [ 3 ]

Abdy Franco made changes - 09/Aug/21 4:03 PM

Remaining Estimate		0 minutes [ 0 ]
Time Spent		45 minutes [ 2700 ]
Worklog Id	15207 [ 15207 ]

Abdy Franco made changes - 09/Aug/21 4:03 PM

Status	In Progress [ 3 ]	In Review [ 5 ]
Resolution		Fixed [ 1 ]

Jonathan Reissmueller made changes - 11/Aug/21 6:05 PM

Fix Version/s		5.1.3 [ 11716 ]
Original Estimate		0 minutes [ 0 ]

Jonathan Reissmueller made changes - 11/Aug/21 6:06 PM

Rank

Ranked higher

Jonathan Reissmueller made changes - 16/Aug/21 12:45 PM

Status

In Review [ 5 ]

Closed [ 6 ]

People

Assignee:

Abdy Franco

Reporter:

Jonathan Reissmueller

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

09/Aug/21 11:35 AM

Updated:

16/Aug/21 12:45 PM

Resolved:

09/Aug/21 4:03 PM

Fix Release Date:

24/Aug/21

Time Tracking

Estimated:

Remaining:

Logged:

45m

Agile

Completed Sprint:

5.2.0 Sprint 3 ended 24/Aug/21
View on Board