[CORE-4453] Coupons can't be applied to hidden packages - Blesta

Jonathan Reissmueller created issue - 07/Sep/21 5:27 PM

Jonathan Reissmueller made changes - 07/Sep/21 5:27 PM

Field	Original Value	New Value
Rank		Ranked higher

Jonathan Reissmueller made changes - 07/Sep/21 5:28 PM

Description

Update app/controllers/admin_company_billing.php starting at line 711 from:

{code:java}

        $package_groups = $this->Form->collapseObjectArray(
            $this->Packages->getAllGroups($this->company_id),
            'name',
            'id'
        );
        $all = ['' => Language::_('AdminCompanyBilling.addcoupon.text_all', true)];
        $package_groups = $all + $package_groups;
        $package_attributes = [];
        $packages = $this->Packages->getAll($this->company_id);

        // Build the package option attributes
        foreach ($packages as $package) {
            $groups = $this->Packages->getAllGroups($this->company_id, $package->id);
{code}

To

{code:java}

        $package_groups = $this->Form->collapseObjectArray(
            $this->Packages->getAllGroups($this->company_id, null, null, ['hidden' => 1]),
            'name',
            'id'
        );
        $all = ['' => Language::_('AdminCompanyBilling.addcoupon.text_all', true)];
        $package_groups = $all + $package_groups;
        $package_attributes = [];
        $packages = $this->Packages->getAll($this->company_id, [], null, null, ['hidden' => 1]);

        // Build the package option attributes
        foreach ($packages as $package) {
            $groups = $this->Packages->getAllGroups($this->company_id, $package->id, null, ['hidden' => 1]);
{code}

And update starting at line 897:

{code:java}
        $package_groups = $this->Form->collapseObjectArray(
            $this->Packages->getAllGroups($this->company_id),
            'name',
            'id'
        );
        $all = ['' => Language::_('AdminCompanyBilling.editcoupon.text_all', true)];
        $package_groups = $all + $package_groups;
        $package_attributes = [];
        $packages = $this->Packages->getAll($this->company_id);

        // Build the package option attributes
        foreach ($packages as $package) {
            $groups = $this->Packages->getAllGroups($this->company_id, $package->id);
{code}

To

{code:java}
        $package_groups = $this->Form->collapseObjectArray(
            $this->Packages->getAllGroups($this->company_id, null, null, ['hidden' => 1]),
            'name',
            'id'
        );
        $all = ['' => Language::_('AdminCompanyBilling.editcoupon.text_all', true)];
        $package_groups = $all + $package_groups;
        $package_attributes = [];
        $packages = $this->Packages->getAll($this->company_id, [], null, null, ['hidden' => 1]);

        // Build the package option attributes
        foreach ($packages as $package) {
            $groups = $this->Packages->getAllGroups($this->company_id, $package->id, null, ['hidden' => 1]);
{code}

Jonathan Reissmueller made changes - 07/Sep/21 6:06 PM

Description

Update app/controllers/admin_company_billing.php starting at line 711 from:

{code:java}

        $package_groups = $this->Form->collapseObjectArray(
            $this->Packages->getAllGroups($this->company_id),
            'name',
            'id'
        );
        $all = ['' => Language::_('AdminCompanyBilling.addcoupon.text_all', true)];
        $package_groups = $all + $package_groups;
        $package_attributes = [];
        $packages = $this->Packages->getAll($this->company_id);

        // Build the package option attributes
        foreach ($packages as $package) {
            $groups = $this->Packages->getAllGroups($this->company_id, $package->id);
{code}

To

{code:java}

        $package_groups = $this->Form->collapseObjectArray(
            $this->Packages->getAllGroups($this->company_id, null, null, ['hidden' => 1]),
            'name',
            'id'
        );
        $all = ['' => Language::_('AdminCompanyBilling.addcoupon.text_all', true)];
        $package_groups = $all + $package_groups;
        $package_attributes = [];
        $packages = $this->Packages->getAll($this->company_id, [], null, null, ['hidden' => 1]);

        // Build the package option attributes
        foreach ($packages as $package) {
            $groups = $this->Packages->getAllGroups($this->company_id, $package->id, null, ['hidden' => 1]);
{code}

And update starting at line 897:

{code:java}
        $package_groups = $this->Form->collapseObjectArray(
            $this->Packages->getAllGroups($this->company_id),
            'name',
            'id'
        );
        $all = ['' => Language::_('AdminCompanyBilling.editcoupon.text_all', true)];
        $package_groups = $all + $package_groups;
        $package_attributes = [];
        $packages = $this->Packages->getAll($this->company_id);

        // Build the package option attributes
        foreach ($packages as $package) {
            $groups = $this->Packages->getAllGroups($this->company_id, $package->id);
{code}

To

{code:java}
        $package_groups = $this->Form->collapseObjectArray(
            $this->Packages->getAllGroups($this->company_id, null, null, ['hidden' => 1]),
            'name',
            'id'
        );
        $all = ['' => Language::_('AdminCompanyBilling.editcoupon.text_all', true)];
        $package_groups = $all + $package_groups;
        $package_attributes = [];
        $packages = $this->Packages->getAll($this->company_id, [], null, null, ['hidden' => 1]);

        // Build the package option attributes
        foreach ($packages as $package) {
            $groups = $this->Packages->getAllGroups($this->company_id, $package->id, null, ['hidden' => 1]);
{code}

Update app/controllers/admin_company_billing.php starting at line 711 from:

{code:java}

        $package_groups = $this->Form->collapseObjectArray(
            $this->Packages->getAllGroups($this->company_id),
            'name',
            'id'
        );
        $all = ['' => Language::_('AdminCompanyBilling.addcoupon.text_all', true)];
        $package_groups = $all + $package_groups;
        $package_attributes = [];
        $packages = $this->Packages->getAll($this->company_id);

        // Build the package option attributes
        foreach ($packages as $package) {
            $groups = $this->Packages->getAllGroups($this->company_id, $package->id);
{code}

To

{code:java}

        $package_groups = $this->Form->collapseObjectArray(
            $this->Packages->getAllGroups($this->company_id, null, null, ['hidden' => 1]),
            'name',
            'id'
        );
        $all = ['' => Language::_('AdminCompanyBilling.addcoupon.text_all', true)];
        $package_groups = $all + $package_groups;
        $package_attributes = [];
        $packages = $this->Packages->getAll($this->company_id, [], null, null, ['hidden' => 1]);

        // Build the package option attributes
        foreach ($packages as $package) {
            $groups = $this->Packages->getAllGroups($this->company_id, $package->id, null, ['hidden' => 1]);
{code}

And update starting at line 897:

{code:java}
        $package_groups = $this->Form->collapseObjectArray(
            $this->Packages->getAllGroups($this->company_id),
            'name',
            'id'
        );
        $all = ['' => Language::_('AdminCompanyBilling.editcoupon.text_all', true)];
        $package_groups = $all + $package_groups;
        $package_attributes = [];
        $packages = $this->Packages->getAll($this->company_id);

        // Build the package option attributes
        foreach ($packages as $package) {
            $groups = $this->Packages->getAllGroups($this->company_id, $package->id);
{code}

To

{code:java}
        $package_groups = $this->Form->collapseObjectArray(
            $this->Packages->getAllGroups($this->company_id, null, null, ['hidden' => 1]),
            'name',
            'id'
        );
        $all = ['' => Language::_('AdminCompanyBilling.editcoupon.text_all', true)];
        $package_groups = $all + $package_groups;
        $package_attributes = [];
        $packages = $this->Packages->getAll($this->company_id, [], null, null, ['hidden' => 1]);

        // Build the package option attributes
        foreach ($packages as $package) {
            $groups = $this->Packages->getAllGroups($this->company_id, $package->id, null, ['hidden' => 1]);
{code}

In core/Pricing/Presenter/Items/Service/AbstractServiceItems.php change line 508 and 526 from:

{code:java}
                case 'service':
{code}

To

{code:java}
                case 'domain':
                case 'service':
{code}

Jonathan Reissmueller made changes - 08/Sep/21 1:42 PM

Sprint

5.2.0 Wrapup [ 142 ]

Jonathan Reissmueller made changes - 08/Sep/21 1:42 PM

Rank

Ranked lower

Jonathan Reissmueller made changes - 08/Sep/21 1:42 PM

Rank

Ranked higher

Jonathan Reissmueller made changes - 08/Sep/21 1:43 PM

Fix Version/s		5.2.0-b1 [ 11709 ]
Fix Version/s	Short Term [ 10800 ]

Abdy Franco made changes - 08/Sep/21 2:55 PM

Assignee

Abdy Franco [ abdy ]

Abdy Franco made changes - 08/Sep/21 2:55 PM

Status

Open [ 1 ]

In Progress [ 3 ]

Abdy Franco made changes - 08/Sep/21 4:06 PM

Status	In Progress [ 3 ]	In Review [ 5 ]
Resolution		Fixed [ 1 ]

Abdy Franco made changes - 08/Sep/21 4:06 PM

Remaining Estimate		0 minutes [ 0 ]
Time Spent		1 hour, 22 minutes [ 4920 ]
Worklog Id	15268 [ 15268 ]

Jonathan Reissmueller made changes - 09/Sep/21 5:18 PM

Status

In Review [ 5 ]

Closed [ 6 ]

Coupons can't be applied to hidden packages

Details

Description

Activity

People

Dates

Time Tracking

Agile