Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Critical
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 5.2.1
-
Component/s: None
-
Labels:None
Description
[2021-10-25T16:03:59.352568+00:00] general.ERROR: Uncaught Exception Error: "Call to undefined method TaxProviders::getNotes()" at .../components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php line 678 {"exception":"[object] (Error(code: 0): Call to undefined method TaxProviders::getNotes() at .../components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php:678)"}
To reproduce:
- Change invoice style to quickbooks or perforated
- Download/view an invoice
To resolve update perforated_invoice_pdf.php and quickbooks_invoice_pdf.php and change:
// Set tax notes
$notes = $this->TaxProviders->getNotes($this->invoice->id);
foreach ($notes as $note) {
$data[] = [
'notes' => $note
];
}
To
if (($tax_provider = $this->TaxProviders->getByCountry($this->invoice->client->country))) {
// Set tax notes
$notes = $tax_provider->getNotes($this->invoice);
foreach ($notes as $note) {
$data[] = [
'notes' => $note
];
}
}
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
| Sprint | 5.3.0 Sprint 3 [ 143 ] |
| Rank | Ranked lower |
| Description | {quote}\[2021-10-25T16:03:59.352568+00:00\] general.ERROR: Uncaught Exception Error: "Call to undefined method TaxProviders::getNotes()" at .../components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php line 678 \{"exception":"\[object\] (Error(code: 0): Call to undefined method TaxProviders::getNotes() at .../components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php:678)"\}{quote} |
{quote}\[2021-10-25T16:03:59.352568+00:00\] general.ERROR: Uncaught Exception Error: "Call to undefined method TaxProviders::getNotes()" at .../components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php line 678 \{"exception":"\[object\] (Error(code: 0): Call to undefined method TaxProviders::getNotes() at .../components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php:678)"\}{quote}
To reproduce: * Change invoice style to quickbooks or perforated * Generate an invoice To resolve update perforated_invoice_pdf.php and quickbooks_invoice_pdf.php and change: {code:java} // Set tax notes $notes = $this->TaxProviders->getNotes($this->invoice->id); foreach ($notes as $note) { $data[] = [ 'notes' => $note ]; } {code} To {code:java} if (($tax_provider = $this->TaxProviders->getByCountry($this->invoice->client->country))) { // Set tax notes $notes = $tax_provider->getNotes($this->invoice); foreach ($notes as $note) { $data[] = [ 'notes' => $note ]; } } {code} |
| Priority | Major [ 3 ] | Critical [ 2 ] |
| Description |
{quote}\[2021-10-25T16:03:59.352568+00:00\] general.ERROR: Uncaught Exception Error: "Call to undefined method TaxProviders::getNotes()" at .../components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php line 678 \{"exception":"\[object\] (Error(code: 0): Call to undefined method TaxProviders::getNotes() at .../components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php:678)"\}{quote}
To reproduce: * Change invoice style to quickbooks or perforated * Generate an invoice To resolve update perforated_invoice_pdf.php and quickbooks_invoice_pdf.php and change: {code:java} // Set tax notes $notes = $this->TaxProviders->getNotes($this->invoice->id); foreach ($notes as $note) { $data[] = [ 'notes' => $note ]; } {code} To {code:java} if (($tax_provider = $this->TaxProviders->getByCountry($this->invoice->client->country))) { // Set tax notes $notes = $tax_provider->getNotes($this->invoice); foreach ($notes as $note) { $data[] = [ 'notes' => $note ]; } } {code} |
{quote}\[2021-10-25T16:03:59.352568+00:00\] general.ERROR: Uncaught Exception Error: "Call to undefined method TaxProviders::getNotes()" at .../components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php line 678 \{"exception":"\[object\] (Error(code: 0): Call to undefined method TaxProviders::getNotes() at .../components/invoice_templates/perforated_invoice/perforated_invoice_pdf.php:678)"\}{quote}
To reproduce: * Change invoice style to quickbooks or perforated * Download/view an invoice To resolve update perforated_invoice_pdf.php and quickbooks_invoice_pdf.php and change: {code:java} // Set tax notes $notes = $this->TaxProviders->getNotes($this->invoice->id); foreach ($notes as $note) { $data[] = [ 'notes' => $note ]; } {code} To {code:java} if (($tax_provider = $this->TaxProviders->getByCountry($this->invoice->client->country))) { // Set tax notes $notes = $tax_provider->getNotes($this->invoice); foreach ($notes as $note) { $data[] = [ 'notes' => $note ]; } } {code} |
| Assignee | Jonathan Reissmueller [ jonathan ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Status | In Review [ 5 ] | Closed [ 6 ] |