Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-4618

Remove database transaction for plugin install

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.4.0-b1
    • Component/s: None
    • Labels:
      None

      Description

      Plugin installation is current wrapped in a database transaction (i.e. begin + rollback|commit). This is an issue however because many plugins create database tables, which performs an implicit commit. The PHP 7 PDO pretends like the commit hasn't happened and thus allowed us to make a call to commit|rollback. PHP 8 does not.

      We should remove the database transaction since it causes issues and doesn't actually do anything for plugins that create a database table (which is most).

        Activity

        jonathan Jonathan Reissmueller created issue -
        jonathan Jonathan Reissmueller made changes -
        Field Original Value New Value
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Security Private [ 10000 ]
        jonathan Jonathan Reissmueller made changes -
        Story Points 1
        jonathan Jonathan Reissmueller made changes -
        Sprint 5.5.0 Sprint 1 [ 153 ]
        jonathan Jonathan Reissmueller made changes -
        Rank Ranked higher
        jonathan Jonathan Reissmueller made changes -
        Assignee Jonathan Reissmueller [ jonathan ]
        jonathan Jonathan Reissmueller made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        jonathan Jonathan Reissmueller made changes -
        Status In Progress [ 3 ] In Review [ 5 ]
        Resolution Fixed [ 1 ]
        abdy Abdy Franco made changes -
        Remaining Estimate 0 minutes [ 0 ]
        Time Spent 10 minutes [ 600 ]
        Worklog Id 15643 [ 15643 ]
        jonathan Jonathan Reissmueller made changes -
        Status In Review [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            jonathan Jonathan Reissmueller
            Reporter:
            jonathan Jonathan Reissmueller
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Fix Release Date:
              13/Apr/22

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0 minutes
              0m
              Logged:
              Time Spent - 10 minutes
              10m

                Agile