Details
-
Type: Improvement
-
Status: Closed
-
Priority: Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 5.5.0-b1
-
Component/s: None
-
Labels:None
Description
Implement RegistrarModule::getFilteredTldPricing() by moving the contents from getTldPricing() and updating that function to:
public function getTldPricing($module_row_id = null) { return $this->getFilteredTldPricing($module_row_id); }
We should still fetch all available prices for caching in getFilteredTldPricing(), but only format and return prices that match the criteria. Caching should also be updated to store API results, rather than formatted list of prices (and thus the fetched cache results will need to go through formatting instead of being immediately returned).
Activity
Jonathan Reissmueller
created issue -
Jonathan Reissmueller
made changes -
Field | Original Value | New Value |
---|---|---|
Rank | Ranked higher |
Jonathan Reissmueller
made changes -
Summary | Namecheap: Update to implement getFilteredTldPricing() | Namecheap: Implement getFilteredTldPricing() |
Jonathan Reissmueller
made changes -
Story Points | 3 |
Jonathan Reissmueller
made changes -
Sprint | 5.5.0 Sprint 4 [ 157 ] |
Jonathan Reissmueller
made changes -
Rank | Ranked higher |
Abdy Franco
made changes -
Assignee | Abdy Franco [ abdy ] |
Abdy Franco
made changes -
Remaining Estimate | 0 minutes [ 0 ] | |
Time Spent | 1 hour, 42 minutes [ 6120 ] | |
Worklog Id | 15717 [ 15717 ] |
Abdy Franco
made changes -
Status | Open [ 1 ] | In Review [ 5 ] |
Resolution | Fixed [ 1 ] |
Abdy Franco
made changes -
Time Spent | 1 hour, 42 minutes [ 6120 ] | 1 hour, 57 minutes [ 7020 ] |
Worklog Id | 15726 [ 15726 ] |
Jonathan Reissmueller
made changes -
Status | In Review [ 5 ] | Closed [ 6 ] |