[CORE-4682] Pterodactyl: Allow port in module row hostname field - Blesta

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 5.6.0-b1
Component/s: None
Labels:
None

Description

See https://github.com/blesta/module-pterodactyl/issues/66

In components/modules/pterodactyl/pterodactyl.php around line 408 change

            'host_name' => [
                'valid' => [
                    'rule' => function ($host_name) {
                        $validator = new Server();
                        $parts = explode(':', $host_name);
                        return $validator->isDomain($parts[0]) || $validator->isIp($parts[0]);
                    },
                    'message' => Language::_('Pterodactyl.!error.host_name.valid', true)
                ]
            ],

            'host_name' => [
                'valid' => [
                    'rule' => function ($host_name) {
                        $validator = new Server();
                        $parts = explode(':', $host_name);
                        return ($validator->isDomain($parts[0]) || $validator->isIp($parts[0]))
                            && (!isset($parts[1]) || is_numeric($parts[1]));
                    },
                    'message' => Language::_('Pterodactyl.!error.host_name.valid', true)
                ]
            ],

Activity

Ascending order - Click to sort in descending order

Jonathan Reissmueller created issue - 16/Jun/22 3:51 PM

Jonathan Reissmueller made changes - 16/Jun/22 3:52 PM

Field	Original Value	New Value
Rank		Ranked higher

Jonathan Reissmueller made changes - 16/Jun/22 3:52 PM

Rank

Ranked higher

Jonathan Reissmueller made changes - 16/Jun/22 3:52 PM

Story Points

Jonathan Reissmueller made changes - 16/Jun/22 3:54 PM

Description

In components/modules/pterodactyl/pterodactyl.php around line 408 change

{code:java}
            'host_name' => [
                'valid' => [
                    'rule' => function ($host_name) {
                        $validator = new Server();
                        $parts = explode(':', $host_name);
                        return $validator->isDomain($parts[0]) || $validator->isIp($parts[0]);
                    },
                    'message' => Language::_('Pterodactyl.!error.host_name.valid', true)
                ]
            ],
{code}

To

{code:java}
            'host_name' => [
                'valid' => [
                    'rule' => function ($host_name) {
                        $validator = new Server();
                        $parts = explode(':', $host_name);
                        return ($validator->isDomain($parts[0]) || $validator->isIp($parts[0]))
                            && is_numeric($parts[1]);
                    },
                    'message' => Language::_('Pterodactyl.!error.host_name.valid', true)
                ]
            ],
{code}

See https://github.com/blesta/module-pterodactyl/issues/66

In components/modules/pterodactyl/pterodactyl.php around line 408 change

{code:java}
            'host_name' => [
                'valid' => [
                    'rule' => function ($host_name) {
                        $validator = new Server();
                        $parts = explode(':', $host_name);
                        return $validator->isDomain($parts[0]) || $validator->isIp($parts[0]);
                    },
                    'message' => Language::_('Pterodactyl.!error.host_name.valid', true)
                ]
            ],
{code}

To

{code:java}
            'host_name' => [
                'valid' => [
                    'rule' => function ($host_name) {
                        $validator = new Server();
                        $parts = explode(':', $host_name);
                        return ($validator->isDomain($parts[0]) || $validator->isIp($parts[0]))
                            && is_numeric($parts[1]);
                    },
                    'message' => Language::_('Pterodactyl.!error.host_name.valid', true)
                ]
            ],
{code}

Jonathan Reissmueller made changes - 16/Jun/22 3:57 PM

Security

Private [ 10000 ]

Jonathan Reissmueller made changes - 16/Jun/22 4:12 PM

Description

See https://github.com/blesta/module-pterodactyl/issues/66

In components/modules/pterodactyl/pterodactyl.php around line 408 change

{code:java}
            'host_name' => [
                'valid' => [
                    'rule' => function ($host_name) {
                        $validator = new Server();
                        $parts = explode(':', $host_name);
                        return $validator->isDomain($parts[0]) || $validator->isIp($parts[0]);
                    },
                    'message' => Language::_('Pterodactyl.!error.host_name.valid', true)
                ]
            ],
{code}

To

{code:java}
            'host_name' => [
                'valid' => [
                    'rule' => function ($host_name) {
                        $validator = new Server();
                        $parts = explode(':', $host_name);
                        return ($validator->isDomain($parts[0]) || $validator->isIp($parts[0]))
                            && (!isset($parts[1]) || is_numeric($parts[1]));
                    },
                    'message' => Language::_('Pterodactyl.!error.host_name.valid', true)
                ]
            ],
{code}

Jonathan Reissmueller made changes - 16/Jun/22 4:12 PM

Security

Private [ 10000 ]

Jonathan Reissmueller made changes - 23/Jun/22 3:24 PM

Sprint

5.6.0 Sprint 1 [ 156 ]

Jonathan Reissmueller made changes - 18/Aug/22 3:37 PM

Sprint

5.6.0 Sprint 1 [ 156 ]

5.6.0/5.5.1 [ 166 ]

Jonathan Reissmueller made changes - 18/Aug/22 3:37 PM

Rank

Ranked lower

Abdy Franco made changes - 07/Sep/22 11:09 AM

Assignee

Abdy Franco [ abdy ]

Abdy Franco made changes - 07/Sep/22 11:09 AM

Status

Open [ 1 ]

In Progress [ 3 ]

Abdy Franco made changes - 07/Sep/22 11:22 AM

Status	In Progress [ 3 ]	In Review [ 5 ]
Resolution		Fixed [ 1 ]

Abdy Franco made changes - 07/Sep/22 11:22 AM

Remaining Estimate		0 minutes [ 0 ]
Time Spent		13 minutes [ 780 ]
Worklog Id	15937 [ 15937 ]

Jonathan Reissmueller made changes - 08/Sep/22 10:40 AM

Sprint

5.6.0 Sprint 1/5.5.1 [ 166 ]

5.6.0 Sprint 1/5.5.1, 5.6.0 Sprint 2 [ 166, 167 ]

Jonathan Reissmueller made changes - 08/Sep/22 10:40 AM

Rank

Ranked higher

Jonathan Reissmueller made changes - 09/Sep/22 4:10 PM

Status

In Review [ 5 ]

Closed [ 6 ]

People

Assignee:

Abdy Franco

Reporter:

Jonathan Reissmueller

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

16/Jun/22 3:51 PM

Updated:

09/Sep/22 4:10 PM

Resolved:

07/Sep/22 11:22 AM

Fix Release Date:

15/Nov/22

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

13m

Agile

Completed Sprints:

5.6.0 Sprint 1/5.5.1 ended 08/Sep/22
5.6.0 Sprint 2 ended 23/Sep/22
View on Board