Uploaded image for project: 'Blesta Core'
  1. Blesta Core
  2. CORE-4692

Update package edit to prevent term alteration for in-use pricing

        Details

        • Type: Improvement
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: 5.6.0-b1
        • Component/s: None
        • Labels:
          None

          Description

          Currently, we prevent deleting a package pricing that is in use by a service. We should also prevent changing the term, period, or currency on an in-use pricing. This should likely a front-end field disabling and a back-end validation rule

            Activity

            Ascending order - Click to sort in descending order
            jonathan Jonathan Reissmueller created issue -
            jonathan Jonathan Reissmueller made changes -
            Field Original Value New Value
            Rank Ranked higher
            jonathan Jonathan Reissmueller made changes -
            Rank Ranked higher
            jonathan Jonathan Reissmueller made changes -
            Story Points 3
            jonathan Jonathan Reissmueller made changes -
            Sprint 5.6.0 Sprint 2 [ 158 ]
            jonathan Jonathan Reissmueller made changes -
            Rank Ranked lower
            jonathan Jonathan Reissmueller made changes -
            Rank Ranked higher
            jonathan Jonathan Reissmueller made changes -
            Sprint 5.6.0 Sprint 3 [ 158 ] 5.6.0 Sprint 2 [ 167 ]
            jonathan Jonathan Reissmueller made changes -
            Rank Ranked higher
            jonathan Jonathan Reissmueller made changes -
            Rank Ranked lower
            jonathan Jonathan Reissmueller made changes -
            Sprint 5.6.0 Sprint 2 [ 167 ] 5.6.0 Sprint 3 [ 158 ]
            jonathan Jonathan Reissmueller made changes -
            Rank Ranked lower
            abdy Abdy Franco made changes -
            Assignee Abdy Franco [ abdy ]
            abdy Abdy Franco made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            abdy Abdy Franco made changes -
            Remaining Estimate 0 minutes [ 0 ]
            Time Spent 6 hours, 25 minutes [ 23100 ]
            Worklog Id 15964 [ 15964 ]
            abdy Abdy Franco made changes -
            Status In Progress [ 3 ] In Review [ 5 ]
            Resolution Fixed [ 1 ]
            jonathan Jonathan Reissmueller made changes -
            Time Spent 6 hours, 25 minutes [ 23100 ] 7 hours, 23 minutes [ 26580 ]
            Worklog Id 15974 [ 15974 ]
            jonathan Jonathan Reissmueller made changes -
            Sprint 5.6.0 Sprint 3 [ 158 ] 5.6.0 Sprint 3, 5.6.0 Sprint 4 [ 158, 168 ]
            jonathan Jonathan Reissmueller made changes -
            Rank Ranked higher
            abdy Abdy Franco made changes -
            Time Spent 7 hours, 23 minutes [ 26580 ] 1 day, 1 hour, 14 minutes [ 33240 ]
            Worklog Id 15994 [ 15994 ]
            jonathan Jonathan Reissmueller made changes -
            Status In Review [ 5 ] Closed [ 6 ]
            Hide
            Permalink
            admin Paul Phillips added a comment -

            I can edit Term, Period, and Currency of a package that is in use. I spot checked the pull request in blesta-5.6.0-b1-build367 and the changes appear to be in this build, however it doesn't seem to work.

            To reproduce:

            1. Create a package with a price, say 1 month USD $5
            2. Add a service to a client using the package
            3. Edit the package and change term, or period or currency
            4. Note that it's updated without any error

            Show
            admin Paul Phillips added a comment - I can edit Term, Period, and Currency of a package that is in use. I spot checked the pull request in blesta-5.6.0-b1-build367 and the changes appear to be in this build, however it doesn't seem to work. To reproduce: 1. Create a package with a price, say 1 month USD $5 2. Add a service to a client using the package 3. Edit the package and change term, or period or currency 4. Note that it's updated without any error
            admin Paul Phillips made changes -
            Resolution Fixed [ 1 ]
            Status Closed [ 6 ] Reopened [ 4 ]
            admin Paul Phillips made changes -
            Assignee Abdy Franco [ abdy ] Jonathan Reissmueller [ jonathan ]
            jonathan Jonathan Reissmueller made changes -
            Sprint 5.6.0 Sprint 3, 5.6.0 Sprint 4 [ 158, 168 ] 5.6.0 Sprint 3, 5.6.0 Sprint 4, 5.6.0-b1 Sprint x [ 158, 168, 170 ]
            jonathan Jonathan Reissmueller made changes -
            Status Reopened [ 4 ] In Review [ 5 ]
            Resolution Fixed [ 1 ]
            jonathan Jonathan Reissmueller made changes -
            Time Spent 1 day, 1 hour, 14 minutes [ 33240 ] 1 day, 1 hour, 34 minutes [ 34440 ]
            Worklog Id 16033 [ 16033 ]
            jonathan Jonathan Reissmueller made changes -
            Status In Review [ 5 ] Closed [ 6 ]

              People

              • Assignee:
                jonathan Jonathan Reissmueller
                Reporter:
                jonathan Jonathan Reissmueller
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  15/Nov/22

                  Time Tracking

                  Estimated:
                  Original Estimate - Not Specified
                  Not Specified
                  Remaining:
                  Remaining Estimate - 0 minutes
                  0m
                  Logged:
                  Time Spent - 1 day, 1 hour, 34 minutes
                  1d 1h 34m

                    Agile