[CORE-4722] Remove unnecessary database transaction from Transactions::applyFromCredits() - Blesta

Jonathan Reissmueller created issue - 12/Jul/22 5:10 PM

Jonathan Reissmueller made changes - 12/Jul/22 5:10 PM

Field	Original Value	New Value
Rank		Ranked higher

Jonathan Reissmueller made changes - 12/Jul/22 5:12 PM

Description

Database transactions are not nestable in MinPHP and thus should be avoided when possible. We can remove one from Transactions::applyFromCredits() by using Transactions::unapply()

Change

{code:java}

        // Begin a transaction
        $this->begin();

        // Apply all credits
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                // Roll back
                $this->rollBack();
                return;
            }
        }

        // Commit transaction
        $this->commit();
{code}

To

{code:java}
        // Apply all credits
        $last_transaction_id = null;
        $errors = null;
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                break;
            }
            $last_transaction_id = $transaction_id;
        }

        if ($errors && $last_transaction_id) {
            foreach ($apply_amounts as $transaction_id => $trans_amounts) {
                $invoice_ids = array_map(function ($value) { return $value['invoice_id']; }, $trans_amounts);
                $this->unapply($transaction_id, $invoice_ids);

                if ($last_transaction_id == $transaction_id) {
                    break;
                }
            }
        }
{code}

Database transactions are not nestable in MinPHP and thus should be avoided when possible. We can remove one from Transactions::applyFromCredits() by using Transactions::unapply()

Change app/models/transactions.php around line

{code:java}

        // Begin a transaction
        $this->begin();

        // Apply all credits
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                // Roll back
                $this->rollBack();
                return;
            }
        }

        // Commit transaction
        $this->commit();
{code}

To

{code:java}
        // Apply all credits
        $last_transaction_id = null;
        $errors = null;
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                break;
            }
            $last_transaction_id = $transaction_id;
        }

        if ($errors && $last_transaction_id) {
            foreach ($apply_amounts as $transaction_id => $trans_amounts) {
                $invoice_ids = array_map(function ($value) { return $value['invoice_id']; }, $trans_amounts);
                $this->unapply($transaction_id, $invoice_ids);

                if ($last_transaction_id == $transaction_id) {
                    break;
                }
            }
        }
{code}

Jonathan Reissmueller made changes - 12/Jul/22 5:12 PM

Description

Database transactions are not nestable in MinPHP and thus should be avoided when possible. We can remove one from Transactions::applyFromCredits() by using Transactions::unapply()

Change app/models/transactions.php around line

{code:java}

        // Begin a transaction
        $this->begin();

        // Apply all credits
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                // Roll back
                $this->rollBack();
                return;
            }
        }

        // Commit transaction
        $this->commit();
{code}

To

{code:java}
        // Apply all credits
        $last_transaction_id = null;
        $errors = null;
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                break;
            }
            $last_transaction_id = $transaction_id;
        }

        if ($errors && $last_transaction_id) {
            foreach ($apply_amounts as $transaction_id => $trans_amounts) {
                $invoice_ids = array_map(function ($value) { return $value['invoice_id']; }, $trans_amounts);
                $this->unapply($transaction_id, $invoice_ids);

                if ($last_transaction_id == $transaction_id) {
                    break;
                }
            }
        }
{code}

Database transactions are not nestable in MinPHP and thus should be avoided when possible. We can remove one from Transactions::applyFromCredits() by using Transactions::unapply()

Change app/models/transactions.php around line 875 from

{code:java}

        // Begin a transaction
        $this->begin();

        // Apply all credits
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                // Roll back
                $this->rollBack();
                return;
            }
        }

        // Commit transaction
        $this->commit();
{code}

To

{code:java}
        // Apply all credits
        $last_transaction_id = null;
        $errors = null;
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                break;
            }
            $last_transaction_id = $transaction_id;
        }

        if ($errors && $last_transaction_id) {
            foreach ($apply_amounts as $transaction_id => $trans_amounts) {
                $invoice_ids = array_map(function ($value) { return $value['invoice_id']; }, $trans_amounts);
                $this->unapply($transaction_id, $invoice_ids);

                if ($last_transaction_id == $transaction_id) {
                    break;
                }
            }
        }
{code}

Jonathan Reissmueller made changes - 12/Jul/22 5:13 PM

Story Points

2

Jonathan Reissmueller made changes - 12/Jul/22 5:29 PM

Sprint

5.5.0-b2 Sprint 1 [ 163 ]

Jonathan Reissmueller made changes - 12/Jul/22 5:29 PM

Rank

Ranked higher

Jonathan Reissmueller made changes - 12/Jul/22 5:29 PM

Fix Version/s		5.5.0-b2 [ 11733 ]
Fix Version/s	5.6.0-b1 [ 11730 ]

Jonathan Reissmueller made changes - 12/Jul/22 5:57 PM

Description

Database transactions are not nestable in MinPHP and thus should be avoided when possible. We can remove one from Transactions::applyFromCredits() by using Transactions::unapply()

Change app/models/transactions.php around line 875 from

{code:java}

        // Begin a transaction
        $this->begin();

        // Apply all credits
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                // Roll back
                $this->rollBack();
                return;
            }
        }

        // Commit transaction
        $this->commit();
{code}

To

{code:java}
        // Apply all credits
        $last_transaction_id = null;
        $errors = null;
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                break;
            }
            $last_transaction_id = $transaction_id;
        }

        if ($errors && $last_transaction_id) {
            foreach ($apply_amounts as $transaction_id => $trans_amounts) {
                $invoice_ids = array_map(function ($value) { return $value['invoice_id']; }, $trans_amounts);
                $this->unapply($transaction_id, $invoice_ids);

                if ($last_transaction_id == $transaction_id) {
                    break;
                }
            }
        }
{code}

Database transactions are not nestable and thus should be avoided when possible. We can remove one from Transactions::applyFromCredits() by using Transactions::unapply()

Change app/models/transactions.php around line 875 from

{code:java}

        // Begin a transaction
        $this->begin();

        // Apply all credits
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                // Roll back
                $this->rollBack();
                return;
            }
        }

        // Commit transaction
        $this->commit();
{code}

To

{code:java}
        // Apply all credits
        $last_transaction_id = null;
        $errors = null;
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                break;
            }
            $last_transaction_id = $transaction_id;
        }

        if ($errors && $last_transaction_id) {
            foreach ($apply_amounts as $transaction_id => $trans_amounts) {
                $invoice_ids = array_map(function ($value) { return $value['invoice_id']; }, $trans_amounts);
                $this->unapply($transaction_id, $invoice_ids);

                if ($last_transaction_id == $transaction_id) {
                    break;
                }
            }
        }
{code}

Jonathan Reissmueller made changes - 12/Jul/22 5:57 PM

Description

Database transactions are not nestable and thus should be avoided when possible. We can remove one from Transactions::applyFromCredits() by using Transactions::unapply()

Change app/models/transactions.php around line 875 from

{code:java}

        // Begin a transaction
        $this->begin();

        // Apply all credits
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                // Roll back
                $this->rollBack();
                return;
            }
        }

        // Commit transaction
        $this->commit();
{code}

To

{code:java}
        // Apply all credits
        $last_transaction_id = null;
        $errors = null;
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                break;
            }
            $last_transaction_id = $transaction_id;
        }

        if ($errors && $last_transaction_id) {
            foreach ($apply_amounts as $transaction_id => $trans_amounts) {
                $invoice_ids = array_map(function ($value) { return $value['invoice_id']; }, $trans_amounts);
                $this->unapply($transaction_id, $invoice_ids);

                if ($last_transaction_id == $transaction_id) {
                    break;
                }
            }
        }
{code}

Database transactions are not nestable (mostly) and thus should be avoided when possible. We can remove one from Transactions::applyFromCredits() by using Transactions::unapply()

Change app/models/transactions.php around line 875 from

{code:java}

        // Begin a transaction
        $this->begin();

        // Apply all credits
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                // Roll back
                $this->rollBack();
                return;
            }
        }

        // Commit transaction
        $this->commit();
{code}

To

{code:java}
        // Apply all credits
        $last_transaction_id = null;
        $errors = null;
        foreach ($apply_amounts as $transaction_id => $trans_amounts) {
            $this->apply($transaction_id, ['amounts' => $trans_amounts]);

            if (($errors = $this->errors())) {
                break;
            }
            $last_transaction_id = $transaction_id;
        }

        if ($errors && $last_transaction_id) {
            foreach ($apply_amounts as $transaction_id => $trans_amounts) {
                $invoice_ids = array_map(function ($value) { return $value['invoice_id']; }, $trans_amounts);
                $this->unapply($transaction_id, $invoice_ids);

                if ($last_transaction_id == $transaction_id) {
                    break;
                }
            }
        }
{code}

Abdy Franco made changes - 13/Jul/22 10:17 AM

Assignee

Abdy Franco [ abdy ]

Abdy Franco made changes - 13/Jul/22 10:17 AM

Status

Open [ 1 ]

In Progress [ 3 ]

Jonathan Reissmueller made changes - 13/Jul/22 10:41 AM

Sprint

5.5.0-b2 Sprint 1 [ 163 ]

5.5.0 Sprint 1 [ 164 ]

Jonathan Reissmueller made changes - 13/Jul/22 10:41 AM

Rank

Ranked higher

Jonathan Reissmueller made changes - 13/Jul/22 10:45 AM

Fix Version/s		5.5.0 [ 11734 ]
Fix Version/s	5.5.0-b2 [ 11733 ]

Abdy Franco made changes - 13/Jul/22 1:03 PM

Remaining Estimate		0 minutes [ 0 ]
Time Spent		58 minutes [ 3480 ]
Worklog Id	15862 [ 15862 ]

Abdy Franco made changes - 13/Jul/22 1:03 PM

Status	In Progress [ 3 ]	In Review [ 5 ]
Resolution		Fixed [ 1 ]

Jonathan Reissmueller made changes - 20/Jul/22 11:14 AM

Status

In Review [ 5 ]

Closed [ 6 ]

Remove unnecessary database transaction from Transactions::applyFromCredits()

Details

Description

Activity

People

Dates

Time Tracking

Agile