[CORE-4776] Prevent emails to empty recipient list - Blesta

Details

Type: Improvement
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 5.7.0-b1
Component/s: None
Labels:
None

Description

Add a validation rule to prevent emails from being sent to empty recipient list.

Activity

Ascending order - Click to sort in descending order

Jonathan Reissmueller created issue - 26/Oct/22 3:12 PM

Jonathan Reissmueller made changes - 26/Oct/22 3:12 PM

Field	Original Value	New Value
Rank		Ranked higher

Jonathan Reissmueller made changes - 26/Oct/22 3:12 PM

Story Points

Jonathan Reissmueller made changes - 26/Oct/22 3:12 PM

Sprint

5.7.0 Sprint 1 [ 169 ]

Jonathan Reissmueller made changes - 26/Oct/22 3:12 PM

Assignee

Jonathan Reissmueller [ jonathan ]

Hide

Permalink

Jonathan Reissmueller added a comment - 26/Oct/22 3:37 PM

In app/models/emails.php around line 1262 change

        // Set the to addresses
        $rules['to_addresses'] = [
            'format' => [
                'rule' => [[$this, 'validateEmailAddresses'], (isset($vars['to_addresses']) ? $vars['to_addresses'] : null)],
                'message' => $this->_('Emails.!error.to_addresses.format')
            ]
        ];

        // Set the to addresses
        $rules['to_addresses'] = [
            'empty' => [
                'rule' => 'isEmpty',
                'negate' => true,
                'message' => $this->_('Emails.!error.to_addresses.empty')
            ],
            'format' => [
                'rule' => [[$this, 'validateEmailAddresses'], (isset($vars['to_addresses']) ? $vars['to_addresses'] : null)],
                'message' => $this->_('Emails.!error.to_addresses.format')
            ]
        ];

In language/en_us/emails.php around line 40 change

$lang['Emails.!error.action.exists'] = 'The action given is an invalid email group action.';

$lang['Emails.!error.action.exists'] = 'The action given is an invalid email group action.';
$lang['Emails.!error.to_addresses.empty'] = 'At least one To address must be provided.';

Show

Jonathan Reissmueller added a comment - 26/Oct/22 3:37 PM In app/models/emails.php around line 1262 change // Set the to addresses $rules['to_addresses'] = [ 'format' => [ 'rule' => [[$ this , 'validateEmailAddresses'], (isset($vars['to_addresses']) ? $vars['to_addresses'] : null )], 'message' => $ this ->_('Emails.!error.to_addresses.format') ] ]; To // Set the to addresses $rules['to_addresses'] = [ 'empty' => [ 'rule' => 'isEmpty', 'negate' => true , 'message' => $ this ->_('Emails.!error.to_addresses.empty') ], 'format' => [ 'rule' => [[$ this , 'validateEmailAddresses'], (isset($vars['to_addresses']) ? $vars['to_addresses'] : null )], 'message' => $ this ->_('Emails.!error.to_addresses.format') ] ]; In language/en_us/emails.php around line 40 change $lang['Emails.!error.action.exists'] = 'The action given is an invalid email group action.'; To $lang['Emails.!error.action.exists'] = 'The action given is an invalid email group action.'; $lang['Emails.!error.to_addresses.empty'] = 'At least one To address must be provided.';

Abdy Franco made changes - 02/Nov/22 6:19 PM

Status	Open [ 1 ]	In Review [ 5 ]
Resolution		Fixed [ 1 ]

Abdy Franco made changes - 02/Nov/22 6:19 PM

Status

In Review [ 5 ]

Closed [ 6 ]

Abdy Franco made changes - 02/Nov/22 6:19 PM

Sprint

5.7.0 Sprint 1 [ 169 ]

People

Assignee:

Jonathan Reissmueller

Reporter:

Jonathan Reissmueller

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

26/Oct/22 3:12 PM

Updated:

02/Nov/22 6:19 PM

Resolved:

02/Nov/22 6:19 PM

Fix Release Date:

4/May/23

Agile

View on Board