Details
-
Type:
Improvement
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 5.7.0-b1
-
Component/s: None
-
Labels:None
Description
Plugins often want to know when a service is being activated. We should a boolean 'service_activated' that contains this info so the plugin doesn't have to do it's own evaluation.
Something like changing
// Trigger the Services.addAfter event
$this->executeAndParseEvent('Services.addAfter', ['service_id' => $service_id, 'vars' => $vars]);
To
// Trigger the Services.addAfter event
$this->executeAndParseEvent(
'Services.addAfter',
[
'service_id' => $service_id,
'vars' => $vars,
'service_activated' => ($vars['status'] ?? null) == 'active'
]
);
And similar for edit that checks if the status is being changed from pending to active.
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
| Story Points | 2 |
| Fix Version/s | 5.7.0-b1 [ 11737 ] |
| Sprint | 5.7.0 Sprint 1 [ 169 ] |
| Rank | Ranked higher |
| Assignee | Abdy Franco [ abdy ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Remaining Estimate | 0 minutes [ 0 ] | |
| Time Spent | 1 hour, 5 minutes [ 3900 ] | |
| Worklog Id | 16064 [ 16064 ] |
| Status | In Progress [ 3 ] | In Review [ 5 ] |
| Resolution | Fixed [ 1 ] |
| Sprint | 5.7.0 Sprint 1 [ 169 ] | 5.7.0 Sprint 1, 5.7.0 Sprint 2 [ 169, 171 ] |
| Rank | Ranked higher |
| Sprint | 5.7.0 Sprint 1, 5.7.0 Sprint 2 [ 169, 171 ] | 5.7.0 Sprint 1, 5.7.0 Sprint 2, 5.7.0 Sprint 3 [ 169, 171, 172 ] |
| Rank | Ranked higher |
| Sprint | 5.7.0 Sprint 1, 5.7.0 Sprint 2, 5.7.0 Sprint 3 [ 169, 171, 172 ] | 5.7.0 Sprint 1, 5.7.0 Sprint 2, 5.7.0 Sprint 3, 5.7.0 Sprint 4 [ 169, 171, 172, 173 ] |
| Rank | Ranked higher |
| Time Spent | 1 hour, 5 minutes [ 3900 ] | 1 hour, 17 minutes [ 4620 ] |
| Worklog Id | 16118 [ 16118 ] |
| Status | In Review [ 5 ] | Closed [ 6 ] |
