[CORE-4832] Stripe Payments: Fatal error on payment error - Blesta

Details

Type: Bug
Status: Closed
Priority: Major
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 5.6.1
Component/s: None
Labels:
None

Description

Error: Cannot use object of type stdClass as array #0 /components/gateway_payments/gateway_payments.php(755): StripePayments->processStoredCc()

I haven't reproduced personally yet but my understanding is that this would occur on a declined payment

Activity

Ascending order - Click to sort in descending order

Jonathan Reissmueller created issue - 09/Jan/23 12:11 PM

Jonathan Reissmueller made changes - 09/Jan/23 12:11 PM

Field	Original Value	New Value
Rank		Ranked higher

Jonathan Reissmueller made changes - 09/Jan/23 12:12 PM

Sprint

5.7.0 Sprint 4 [ 173 ]

Jonathan Reissmueller made changes - 09/Jan/23 12:12 PM

Rank

Ranked higher

Hide

Permalink

Jonathan Reissmueller added a comment - 09/Jan/23 12:13 PM

This may be a bit excessive but this is one solution.

In components/gateways/merchant/stripe_payments/stripe_payments.php around line 707 change:

        if (isset($payment['error'])
            && (isset($payment['error']['code']) ? $payment['error']['code'] : null) === 'card_declined'
        ) {
            $status = 'declined';
        } elseif (!isset($payment->error)
            && empty($errors)
            && isset($payment->status)
            && $payment->status === 'succeeded'
        ) {
            $status = 'approved';
        } else {
            $message = isset($payment->error)
                ? (isset($payment->error->message) ? $payment->error->message : null)
                : (isset($payment['error']['message']) ? $payment['error']['message'] : '');
        }

        if ((is_array($payment)
                && isset($payment['error'])
                && (isset($payment['error']['code']) ? $payment['error']['code'] : null) === 'card_declined'
            ) || (is_object($payment)
                && isset($payment->error)
                && (isset($payment->error->code) ? $payment->error->code : null) === 'card_declined'
            )
        ) {
            $status = 'declined';
        } elseif (!isset($payment->error)
            && empty($errors)
            && isset($payment->status)
            && $payment->status === 'succeeded'
        ) {
            $status = 'approved';
        } else {
            $message = (is_object($payment) && isset($payment->error))
                ? (isset($payment->error->message) ? $payment->error->message : null)
                : ((is_array($payment) && isset($payment['error']['message'])) ? $payment['error']['message'] : null);
        }

Show

Jonathan Reissmueller added a comment - 09/Jan/23 12:13 PM This may be a bit excessive but this is one solution. In components/gateways/merchant/stripe_payments/stripe_payments.php around line 707 change: if (isset($payment['error']) && (isset($payment['error']['code']) ? $payment['error']['code'] : null ) === 'card_declined' ) { $status = 'declined'; } elseif (!isset($payment->error) && empty($errors) && isset($payment->status) && $payment->status === 'succeeded' ) { $status = 'approved'; } else { $message = isset($payment->error) ? (isset($payment->error->message) ? $payment->error->message : null ) : (isset($payment['error']['message']) ? $payment['error']['message'] : ''); } To if ((is_array($payment) && isset($payment['error']) && (isset($payment['error']['code']) ? $payment['error']['code'] : null ) === 'card_declined' ) || (is_object($payment) && isset($payment->error) && (isset($payment->error->code) ? $payment->error->code : null ) === 'card_declined' ) ) { $status = 'declined'; } elseif (!isset($payment->error) && empty($errors) && isset($payment->status) && $payment->status === 'succeeded' ) { $status = 'approved'; } else { $message = (is_object($payment) && isset($payment->error)) ? (isset($payment->error->message) ? $payment->error->message : null ) : ((is_array($payment) && isset($payment['error']['message'])) ? $payment['error']['message'] : null ); }

Jonathan Reissmueller made changes - 09/Jan/23 12:16 PM

Description

{quote}Error: Cannot use object of type stdClass as array #0 /components/gateway_payments/gateway_payments.php(755): StripePayments->processStoredCc(){quote}

{quote}Error: Cannot use object of type stdClass as array #0 /components/gateway_payments/gateway_payments.php(755): StripePayments->processStoredCc(){quote}

I haven't reproduced personally yet but my understanding is that this would occur on a declined payment

Abdy Franco made changes - 10/Jan/23 6:48 PM

Assignee

Abdy Franco [ abdy ]

Abdy Franco made changes - 10/Jan/23 6:48 PM

Status

Open [ 1 ]

In Progress [ 3 ]

Abdy Franco made changes - 10/Jan/23 6:51 PM

Remaining Estimate		0 minutes [ 0 ]
Time Spent		58 minutes [ 3480 ]
Worklog Id	16114 [ 16114 ]

Abdy Franco made changes - 10/Jan/23 7:02 PM

Status	In Progress [ 3 ]	In Review [ 5 ]
Resolution		Fixed [ 1 ]

Jonathan Reissmueller made changes - 11/Jan/23 2:12 PM

Status

In Review [ 5 ]

Closed [ 6 ]

People

Assignee:

Abdy Franco

Reporter:

Jonathan Reissmueller

Votes:

0 Vote for this issue

Watchers:

1 Start watching this issue

Dates

Created:

09/Jan/23 12:11 PM

Updated:

11/Jan/23 2:12 PM

Resolved:

10/Jan/23 7:02 PM

Fix Release Date:

18/Jan/23

Time Tracking

Estimated:

Not Specified

Remaining:

Logged:

58m

Agile

Completed Sprint:

5.7.0 Sprint 4 ended 03/Mar/23
View on Board